im.pidgin.pidgin: 1d887e0b6d13b709051a68be9b34c28d2254dadb

[khc at pidgin.im]

-----------------------------------------------------------------
Revision: 1d887e0b6d13b709051a68be9b34c28d2254dadb
Ancestor: e5bd56af36e2e12b5e4f0867071fde785733ba54
Author: khc at pidgin.im
Date: 2007-12-16T00:34:21
Branch: im.pidgin.pidgin

Modified files:
        libpurple/protocols/msn/contact.c

ChangeLog: 

part of the series of patches from QuLogic that fixes a use-after-free,
References #4382

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/contact.c	c302c164e8a06a6f832b6cc1efa2f92596ad9118
+++ libpurple/protocols/msn/contact.c	2e49ff88c5f1633912487a21cbf0df32a341d617
@@ -1289,16 +1289,16 @@ msn_group_read_cb(MsnSoapMessage *req, M
 				purple_debug_info("MSNCL", "Adding group %s with guid = %s to the userlist\n", state->new_group_name, guid);
 				msn_group_new(session->userlist, guid, state->new_group_name);
 
-				g_free(guid);
-
 				if (state->action & MSN_ADD_BUDDY) {
 					msn_userlist_add_buddy(session->userlist,
 						state->who,
 						state->new_group_name);
 				} else if (state->action & MSN_MOVE_BUDDY) {
 					msn_add_contact_to_group(session->contact, state, state->who, guid); 
+					g_free(guid);
 					return;
 				}
+				g_free(guid);
 			} else {
 				purple_debug_info("MSNCL", "Adding group %s failed\n",
 					state->new_group_name);