[Commits] Revision 31645f8874eea1206215dc6625cda5d231b4c2d6

monotone server user monotone at pidgin.im
Sun Feb 4 02:24:47 EST 2007

Revision: 31645f8874eea1206215dc6625cda5d231b4c2d6
Ancestor: 5fb52dbca5baeafcdd38f721a28ac87cef27ebb8
Author: rlaager at pidgin.im
Date: 2007-02-04T06:46:31
Branch: im.pidgin.pidgin

Modified files:


Fix SF Bug #1644796

In old_logger_read, we call g_markup_escape_text() on data from the
filesystem without verifying that it's valid UTF-8. Björn Voigt says this
can cause crashes.  I have no idea if that's true or not, but either way,
we should always be validating data on the way in.  I've refactored some
code to eliminate duplication and make things clearer.  I'm also avoiding
an unnecessary g_strdup() of the entire conversation in txt_logger_read()
in some cases.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 31645f8874eea1206215dc6625cda5d231b4c2d6.diff
Type: text/x-diff
Size: 2082 bytes
Desc: not available
Url : http://pidgin.im/pipermail/commits/attachments/20070204/83549f56/attachment.diff 

More information about the Commits mailing list