Revision d59e830c02b5909e91b567258fca78dc9af8e282
sadrul at pidgin.im
sadrul at pidgin.im
Sun Mar 4 20:13:11 EST 2007
o -----------------------------------------------------------------
| Revision: d59e830c02b5909e91b567258fca78dc9af8e282
| Ancestor: 77fb229680f0342a6684d001bebbd722f3f4d194
| Author: sadrul at pidgin.im
| Date: 2007-03-05T01:26:31
| Branch: im.pidgin.pidgin
|
| Modified files:
| console/libgnt/gnttextview.c console/libgnt/test/tv.c
| console/libgnt/wms/s.c
|
| ChangeLog:
|
| Fix a crash when selecting text in an empty TV.
|
| ============================================================
| --- console/libgnt/gnttextview.c b3b66b77893fd432931f5defff14692eca3cd143
| +++ console/libgnt/gnttextview.c 5c152791907269250a1214666352028971bc9066
| @@ -204,9 +204,9 @@ gnt_text_view_get_p(GntTextView *view, i
| do {
| line = lines->data;
| lines = lines->next;
| - } while (line && !line->segments);
| + } while (line && !line->segments && lines);
|
| - if (!line) /* no valid line */
| + if (!line || !line->segments) /* no valid line */
| return NULL;
| segs = line->segments;
| seg = (GntTextSegment *)segs->data;
| ============================================================
| --- console/libgnt/test/tv.c a48459c9f1599fb61619568505c5fe2c5d6eafa6
| +++ console/libgnt/test/tv.c df77d3d23638996e5d22f096fabe7c21cc878a1c
| @@ -83,6 +83,7 @@ int main()
| gnt_entry_set_history_length(GNT_ENTRY(entry), -1);
| g_signal_connect_after(G_OBJECT(entry), "key_pressed", G_CALLBACK(key_pressed), view);
|
| + gnt_text_view_append_text_with_flags(GNT_TEXT_VIEW(view), "\n", GNT_TEXT_FLAG_NORMAL);
| gnt_text_view_append_text_with_flags(GNT_TEXT_VIEW(view), "plugins: ", GNT_TEXT_FLAG_BOLD);
| gnt_text_view_append_text_with_flags(GNT_TEXT_VIEW(view), "this is the 1st line\n", GNT_TEXT_FLAG_NORMAL);
|
| ============================================================
| --- console/libgnt/wms/s.c 2cd03d376d2625a7d36fca115f4a900b9ffe8b24
| +++ console/libgnt/wms/s.c 4b2ae45e14f3333c6da99240d216465a4972ec93
| @@ -182,7 +182,7 @@ toggle_clipboard(GntBindable *bindable,
| text = gnt_get_clipboard_string();
| clip = gnt_hwindow_new(FALSE);
| GNT_WIDGET_SET_FLAGS(clip, GNT_WIDGET_TRANSIENT);
| - GNT_WIDGET_UNSET_FLAGS(clip, GNT_WIDGET_NO_BORDER);
| + GNT_WIDGET_SET_FLAGS(clip, GNT_WIDGET_NO_BORDER);
| gnt_box_set_pad(GNT_BOX(clip), 0);
| gnt_box_add_widget(GNT_BOX(clip), gnt_label_new(" "));
| gnt_box_add_widget(GNT_BOX(clip), gnt_label_new(text));
To get the patch for this revision, please do this:
mtn log --last 1 --diffs --from d59e830c02b5909e91b567258fca78dc9af8e282
More information about the Commits
mailing list