Revision 433a35a08ab23b80597f5113aefac097640bc4a2

markdoliner at pidgin.im markdoliner at pidgin.im
Sat Mar 24 20:46:41 EDT 2007


o   -----------------------------------------------------------------
|   Revision: 433a35a08ab23b80597f5113aefac097640bc4a2
|   Ancestor: edc9e987c7d0fe871812788dc915ca91a2569a69
|   Author: markdoliner at pidgin.im
|   Date: 2007-03-25T00:45:40
|   Branch: im.pidgin.pidgin
|   
|   Modified files:
|           libpurple/plugin.c
|   
|   ChangeLog: 
|   
|   Get rid of an unnecessary strdup
|   
|   ============================================================
|   --- libpurple/plugin.c	1b7e9f2899a3ea1e04a695b9058a393008d44e55
|   +++ libpurple/plugin.c	721329b7c5935f9b85d48c764f70d610669a9982
|   @@ -369,12 +369,12 @@ purple_plugin_probe(const char *filename
|    		return plugin;
|    	}
|    
|   -	/* 
|   - 	 * Check to make sure a plugin has defined an id.
|   - 	 * Not having this check caused purple_plugin_unload to
|   - 	 * enter an infinite loop in certain situations by passing
|   - 	 * purple_find_plugin_by_id a NULL value. -- ecoffey
|   - 	 */
|   +	/*
|   +	 * Check to make sure a plugin has defined an id.
|   +	 * Not having this check caused purple_plugin_unload to
|   +	 * enter an infinite loop in certain situations by passing
|   +	 * purple_find_plugin_by_id a NULL value. -- ecoffey
|   +	 */
|    	if (!plugin->info->id || !strcmp(plugin->info->id, ""))
|    	{
|    		plugin->error = g_strdup_printf(_("This plugin has not defined an ID."));
|   @@ -672,12 +672,10 @@ purple_plugin_unload(PurplePlugin *plugi
|    		{
|    			if (!purple_plugin_unload(dep_plugin))
|    			{
|   -				char *translated_name = g_strdup(_(dep_plugin->info->name));
|    				char *tmp;
|    
|    				tmp = g_strdup_printf(_("The dependent plugin %s failed to unload."),
|   -				                      translated_name);
|   -				g_free(translated_name);
|   +				                      _(dep_plugin->info->name));
|    
|    				purple_notify_error(NULL, NULL,
|    				                  _("There were errors unloading the plugin."), tmp);

To get the patch for this revision, please do this:
mtn log --last 1 --diffs --from 433a35a08ab23b80597f5113aefac097640bc4a2


More information about the Commits mailing list