Revision 479ec3bc42bb56e872fb1e8d5975ee5cc73f9cb8

rlaager at pidgin.im rlaager at pidgin.im
Tue Mar 27 21:05:23 EDT 2007


o   -----------------------------------------------------------------
|   Revision: 479ec3bc42bb56e872fb1e8d5975ee5cc73f9cb8
|   Ancestor: a7d4dbc1c1e7ecba508354d12ff49fa9ee850bf1
|   Author: rlaager at pidgin.im
|   Date: 2007-03-24T20:25:01
|   Branch: im.pidgin.pidgin
|   
|   Modified files:
|           libpurple/plugin.c
|   
|   ChangeLog: 
|   
|   A small fix to the patch from ecoffey: Gary pointed out that the strcmp()
|   was unnecessary and that the logic could be made more clear.
|   
|   ============================================================
|   --- libpurple/plugin.c	1b7e9f2899a3ea1e04a695b9058a393008d44e55
|   +++ libpurple/plugin.c	9a9b7a2e92b37717cb12a5a00947e99d0855f261
|   @@ -375,7 +375,7 @@ purple_plugin_probe(const char *filename
|     	 * enter an infinite loop in certain situations by passing
|     	 * purple_find_plugin_by_id a NULL value. -- ecoffey
|     	 */
|   -	if (!plugin->info->id || !strcmp(plugin->info->id, ""))
|   +	if (plugin->info->id == NULL || *plugin->info->id == '\0')
|    	{
|    		plugin->error = g_strdup_printf(_("This plugin has not defined an ID."));
|    		purple_debug_error("plugins", "%s is not loadable: info->id is not defined.\n", plugin->path);

To get the patch for this revision, please do this:
mtn log --last 1 --diffs --from 479ec3bc42bb56e872fb1e8d5975ee5cc73f9cb8


More information about the Commits mailing list