im.pidgin.pidgin: d8103be97302efb404e2f6922925f661c807ad23

khc at pidgin.im khc at pidgin.im
Sat Nov 10 00:25:34 EST 2007


-----------------------------------------------------------------
Revision: d8103be97302efb404e2f6922925f661c807ad23
Ancestor: 0784efff2632d42a8b3e26eea0bf130b0fb3fc62
Author: khc at pidgin.im
Date: 2007-11-10T05:20:46
Branch: im.pidgin.pidgin

Modified files:
        libpurple/protocols/msn/nexus.c

ChangeLog: 

Use only the first 16 characters of the password, and plug a leak.

Fixes #3320, thanks phroggie

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/nexus.c	34860e451b2f20f5a4f7c6a71f6a8e93f5e2dff8
+++ libpurple/protocols/msn/nexus.c	bfea87f2cf816d470ab7c527b84c352f8812a2ce
@@ -148,7 +148,7 @@ msn_nexus_connect(MsnNexus *nexus)
 
 	/*prepare the Windows Live ID authentication token*/
 	username = g_strdup(purple_account_get_username(session->account));
-	password = g_strdup(purple_connection_get_password(session->account->gc));
+	password = g_strndup(purple_connection_get_password(session->account->gc), 16);
 
 	lc =	(char *)g_hash_table_lookup(nexus->challenge_data, "lc");
 	id =	(char *)g_hash_table_lookup(nexus->challenge_data, "id");
@@ -212,6 +212,7 @@ msn_nexus_connect(MsnNexus *nexus)
 	g_free(rst3_str);
 #endif
 	g_free(fs);
+	g_free(password);
 
 	soap = msn_soap_message_new(NULL, xmlnode_from_str(tail, -1));
 	g_free(tail);


More information about the Commits mailing list