im.pidgin.cpw.resiak.disconnectreason: 9c6ac6e5bbd0d341259039d91bf74c84337a235c

[resiak at soc.pidgin.im]

revision:            9c6ac6e5bbd0d341259039d91bf74c84337a235c
date:                2007-09-19T11:39:42
author:              resiak at soc.pidgin.im
branch:              im.pidgin.cpw.resiak.disconnectreason
changelog:
Clarified the meaning of PURPLE_REASON_NETWORK_ERROR and
PURPLE_REASON_AUTHENTICATION_FAILED, and added
PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE.  It's not fatal basically because none
of the places in prpl-jabber that need it set wants_to_die --- should it be?

manifest:
format_version "1"

new_manifest [91736136cbec11812dc33b56544ca357e8c14d85]

old_revision [0141fe3770c587a7e64e2925360facc0b003fdca]

patch "libpurple/connection.c"
 from [32be32b2f919f8907fb926548c2cb704a846dccc]
   to [88dcdd279f96ecf42ef0be512e31e8d567db74b0]

patch "libpurple/connection.h"
 from [77f349cf8b13358e8468b2e3e4fb3b013321132e]
   to [c47390c398d40e68551b880bfef86622f0b2d1a9]
-------------- next part --------------
#
#
# patch "libpurple/connection.c"
#  from [32be32b2f919f8907fb926548c2cb704a846dccc]
#    to [88dcdd279f96ecf42ef0be512e31e8d567db74b0]
# 
# patch "libpurple/connection.h"
#  from [77f349cf8b13358e8468b2e3e4fb3b013321132e]
#    to [c47390c398d40e68551b880bfef86622f0b2d1a9]
#
============================================================
--- libpurple/connection.c	32be32b2f919f8907fb926548c2cb704a846dccc
+++ libpurple/connection.c	88dcdd279f96ecf42ef0be512e31e8d567db74b0
@@ -531,6 +531,7 @@ purple_connection_reason_is_fatal (Purpl
 	switch (reason)
 	{
 		case PURPLE_REASON_NETWORK_ERROR:
+		case PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE:
 			return FALSE;
 		case PURPLE_REASON_AUTHENTICATION_FAILED:
 		case PURPLE_REASON_ENCRYPTION_ERROR:
============================================================
--- libpurple/connection.h	77f349cf8b13358e8468b2e3e4fb3b013321132e
+++ libpurple/connection.h	c47390c398d40e68551b880bfef86622f0b2d1a9
@@ -58,10 +58,18 @@ typedef enum
 /** Possible errors that can cause a connection to be closed. */
 typedef enum
 {
-	/** There was an error sending or receiving on the network socket. */
+	/** There was an error sending or receiving on the network socket, or
+	 *  there was some protocol error (such as the server sending malformed
+	 *  data).
+	 */
 	PURPLE_REASON_NETWORK_ERROR = 0,
-	/** The username or password was invalid. */
+	/** The username or password (or some other credential) was incorrect.
+	 */
 	PURPLE_REASON_AUTHENTICATION_FAILED,
+	/** libpurple doesn't speak any of the authentication methods the
+	 *  server offered.
+	 */
+	PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE,
 	/** There was an error negotiating SSL on this connection, or encryption
 	 *  was unavailable and an account option was set to require it.
 	 */