im.pidgin.pidgin: c5051010dd50f9fdb7f85d779d882ce8bbc149f2

datallah at pidgin.im datallah at pidgin.im
Mon Oct 8 20:40:39 EDT 2007


revision:            c5051010dd50f9fdb7f85d779d882ce8bbc149f2
date:                2007-10-09T00:25:56
author:              datallah at pidgin.im
branch:              im.pidgin.pidgin
changelog:
Another couple leak fixes in the xmpp roster parsing.

manifest:
format_version "1"

new_manifest [6372fa07cff2acd945ad9dc2d1c5f4c19a332e7c]

old_revision [5ea15b000ee727088be88bb335c2ded6b2ab96e3]

patch "libpurple/protocols/jabber/roster.c"
 from [1336b167453dd68892ff6a002d454e75ff6f166e]
   to [deb365dab00fc7f261eda9ac73b9309c1af0b8a6]
-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/roster.c	1336b167453dd68892ff6a002d454e75ff6f166e
+++ libpurple/protocols/jabber/roster.c	deb365dab00fc7f261eda9ac73b9309c1af0b8a6
@@ -67,8 +67,10 @@ static void add_purple_buddies_to_groups
 	if(!groups) {
 		if(!buddies)
 			g2 = g_slist_append(g2, g_strdup(_("Buddies")));
-		else
+		else {
+			g_slist_free(buddies);
 			return;
+		}
 	}
 
 	my_bare_jid = g_strdup_printf("%s@%s", js->user->node, js->user->domain);
@@ -267,6 +269,9 @@ static void jabber_roster_update(JabberS
 	JabberIq *iq;
 	xmlnode *query, *item, *group;
 
+	if(!(b = purple_find_buddy(js->gc->account, name)))
+		return;
+
 	if(grps) {
 		groups = grps;
 	} else {
@@ -281,9 +286,6 @@ static void jabber_roster_update(JabberS
 		}
 	}
 
-	if(!(b = purple_find_buddy(js->gc->account, name)))
-		return;
-
 	iq = jabber_iq_new_query(js, JABBER_IQ_SET, "jabber:iq:roster");
 
 	query = xmlnode_get_child(iq->node, "query");


More information about the Commits mailing list