im.pidgin.pidgin: 9293e48140c6404ecc3bca2e74beecded0eb283a

datallah at pidgin.im datallah at pidgin.im
Tue Oct 9 22:09:31 EDT 2007


-----------------------------------------------------------------
Revision: 9293e48140c6404ecc3bca2e74beecded0eb283a
Ancestor: 16b28ccab43bf55eb778e7c45b7b769e11baecfa
Author: datallah at pidgin.im
Date: 2007-10-10T00:44:34
Branch: im.pidgin.pidgin

Modified files:
        libpurple/protocols/oscar/oscar.c

ChangeLog: 

Fix CID 340; potential NULL deref.

-------------- next part --------------
============================================================
--- libpurple/protocols/oscar/oscar.c	78499efe367e1dd47d2e4f129856c3104787ce52
+++ libpurple/protocols/oscar/oscar.c	8a8ac636b05de5af59f7401639454e568d3bd9f8
@@ -1128,8 +1128,10 @@ flap_connection_established_chat(OscarDa
 	aim_clientready(od, conn);
 
 	chatcon = find_oscar_chat_by_conn(gc, conn);
-	chatcon->id = id;
-	chatcon->conv = serv_got_joined_chat(gc, id++, chatcon->show);
+	if (chatcon) {
+		chatcon->id = id;
+		chatcon->conv = serv_got_joined_chat(gc, id++, chatcon->show);
+	}
 }
 
 static void


More information about the Commits mailing list