im.pidgin.pidgin: ce7bc52a1e7b3d401f32806e3c3fe19c759152fc

datallah at pidgin.im datallah at pidgin.im
Mon Oct 15 00:51:02 EDT 2007


-----------------------------------------------------------------
Revision: ce7bc52a1e7b3d401f32806e3c3fe19c759152fc
Ancestor: 78373ac0523b4bcf8530364077593f822030f45d
Author: datallah at pidgin.im
Date: 2007-10-15T04:48:28
Branch: im.pidgin.pidgin

Modified files:
        libpurple/protocols/msn/msn.c

ChangeLog: 

Fix some (rather large) leakage.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/msn.c	1f9100b53886abb18c13b62fa62d9d5980288979
+++ libpurple/protocols/msn/msn.c	9393a24ce7990e575c4d85ed6b6d294de810c62a
@@ -1594,7 +1594,6 @@ msn_got_info(PurpleUtilFetchUrlData *url
 	gboolean sect_info = FALSE;
 	gboolean has_contact_info = FALSE;
 	char *url_buffer;
-	GString *s, *s2;
 	int stripped_len;
 #if PHOTO_SUPPORT
 	char *photo_url_text = NULL;
@@ -1679,11 +1678,6 @@ msn_got_info(PurpleUtilFetchUrlData *url
 	purple_debug_misc("msn", "stripped = %p\n", stripped);
 	purple_debug_misc("msn", "url_buffer = %p\n", url_buffer);
 
-	/* Gonna re-use the memory we've already got for url_buffer */
-	/* No we're not. */
-	s = g_string_sized_new(strlen(url_buffer));
-	s2 = g_string_sized_new(strlen(url_buffer));
-
 	/* General section header */
 	if (has_tooltip_text)
 		purple_notify_user_info_add_section_break(user_info);
@@ -2030,7 +2024,7 @@ msn_got_photo(PurpleUtilFetchUrlData *ur
 		purple_debug_warning("msn", "invalid connection. ignoring buddy photo info.\n");
 		g_free(stripped);
 		g_free(url_buffer);
-		g_free(user_info);
+		purple_notify_user_info_destroy(user_info);
 		g_free(info_data->name);
 		g_free(info_data);
 		g_free(photo_url_text);


More information about the Commits mailing list