im.pidgin.pidgin: 20395453ab17cd8dd060d4d0794affda17e3272f
nosnilmot at pidgin.im
nosnilmot at pidgin.im
Fri Oct 26 09:25:48 EDT 2007
-----------------------------------------------------------------
Revision: 20395453ab17cd8dd060d4d0794affda17e3272f
Ancestor: 1d36a128301cae57a790a087aa9c4ad8d71dad52
Author: nosnilmot at pidgin.im
Date: 2007-10-26T13:22:49
Branch: im.pidgin.pidgin
Modified files:
libpurple/protocols/myspace/user.c
ChangeLog:
Fix this warning:
user.c: In function 'msim_store_user_info_each':
user.c:214: warning: ISO C90 forbids mixed declarations and code
-------------- next part --------------
============================================================
--- libpurple/protocols/myspace/user.c 07fa5d710386c565ad2b91b493e0895adba755b0
+++ libpurple/protocols/myspace/user.c 84748406d4ca2bae5c19366f42f8a806116bf8cf
@@ -203,6 +203,8 @@ msim_store_user_info_each(const gchar *k
/* Ignore because PurpleBuddy knows this already */
g_free(value_str);
} else if (g_str_equal(key_str, "ImageURL") || g_str_equal(key_str, "AvatarURL")) {
+ const gchar *previous_url;
+
if (user->temporary_user) {
/* This user will be destroyed soon; don't try to look up its image or avatar,
* since that won't return immediately and we will end up accessing freed data.
@@ -210,8 +212,6 @@ msim_store_user_info_each(const gchar *k
g_free(value_str);
return;
}
-
- const gchar *previous_url;
if (user->temporary_user) {
/* This user will be destroyed soon; don't try to look up its image or avatar,
@@ -220,7 +220,7 @@ msim_store_user_info_each(const gchar *k
g_free(value_str);
return;
}
-
+
g_free(user->image_url);
user->image_url = value_str;
@@ -233,7 +233,7 @@ msim_store_user_info_each(const gchar *k
NULL, 0, NULL);
return;
}
-
+
/* TODO: use ETag for checksum */
previous_url = purple_buddy_icons_get_checksum_for_user(user->buddy);
More information about the Commits
mailing list