im.pidgin.pidgin: a1750b6bfef2b654e1620a586e4bf6c58bc3a6a9

nosnilmot at nosnilmot at
Sat Oct 27 10:05:43 EDT 2007

Revision: a1750b6bfef2b654e1620a586e4bf6c58bc3a6a9
Ancestor: c3509bf14bc4bd03cc7c631a2329b33df504a825
Author: nosnilmot at
Date: 2007-10-27T13:27:45
Branch: im.pidgin.pidgin

Modified files:


We really don't need to display Blocked: status in the tooltip for every
buddy in a contact on MSN.

-------------- next part --------------
--- libpurple/protocols/msn/msn.c	9de650cbbffad6d2046dda8916c784805bee13f2
+++ libpurple/protocols/msn/msn.c	df3794ee7e9cefc2489b267f9f52e14b7ac5ae0b
@@ -617,7 +617,12 @@ msn_tooltip_text(PurpleBuddy *buddy, Pur
 	 * XXX: blocked icon overlay isn't always accurate for MSN.
 	 * XXX: This can die as soon as purple_privacy_check() knows that
 	 * XXX: this prpl always honors both the allow and deny lists. */
-	if (user)
+	/* While the above comment may be strictly correct (the privacy API needs
+	 * rewriteing), purple_privacy_check() is going to be more accurate at
+	 * indicating whether a particular buddy is going to be able to message
+	 * you, which is the important information that this is trying to convey.
+	 */
+	if (full && user)
 		purple_notify_user_info_add_pair(user_info, _("Blocked"),
 									   ((user->list_op & (1 << MSN_LIST_BL)) ? _("Yes") : _("No")));

More information about the Commits mailing list