im.pidgin.pidgin: 74f5f273ea24887c8df0384ce8795613dfbbd7ee

resiak at soc.pidgin.im resiak at soc.pidgin.im
Sat Oct 27 13:51:18 EDT 2007


-----------------------------------------------------------------
Revision: 74f5f273ea24887c8df0384ce8795613dfbbd7ee
Ancestor: 20395453ab17cd8dd060d4d0794affda17e3272f
Author: resiak at soc.pidgin.im
Date: 2007-10-27T13:27:31
Branch: im.pidgin.pidgin

Modified files:
        libpurple/conversation.h libpurple/prpl.h

ChangeLog: 

Documentation tweaks for the write_conv uiop and for prpl_info.offline_message.

-------------- next part --------------
============================================================
--- libpurple/conversation.h	eb60430c4284de9b9afb23a0a41992d8ca4bc740
+++ libpurple/conversation.h	c722197bafe733ac6cb012fe8f297274b27eabbf
@@ -171,9 +171,12 @@ struct _PurpleConversationUiOps
 	void (*write_im)(PurpleConversation *conv, const char *who,
 	                 const char *message, PurpleMessageFlags flags,
 	                 time_t mtime);
-	/** Write a message to a conversation.  This is used rather than
-	 *  the chat- or im-specific ops for generic messages, such as system
-	 *  messages like "x is now know as y".
+	/** Write a message to a conversation.  This is used rather than the
+	 *  chat- or im-specific ops for errors, system messages (such as "x is
+	 *  now know as y"), and as the fallback if #write_im and #write_chat
+	 *  are not implemented.  It should be implemented, or the UI will miss
+	 *  conversation error messages and your users will hate you.
+	 *
 	 *  @see purple_conversation_write()
 	 */
 	void (*write_conv)(PurpleConversation *conv,
============================================================
--- libpurple/prpl.h	9a9de78462648a490153c2e4345c0ae13cd6e927
+++ libpurple/prpl.h	14ed141daea0038d440af028e16e1095e1e6d1fa
@@ -354,6 +354,11 @@ struct _PurplePluginProtocolInfo
 	gboolean (*can_receive_file)(PurpleConnection *, const char *who);
 	void (*send_file)(PurpleConnection *, const char *who, const char *filename);
 	PurpleXfer *(*new_xfer)(PurpleConnection *, const char *who);
+
+	/** Checks whether offline messages to @a buddy are supported.
+	 *  @return @c TRUE if @a buddy can be sent messages while they are
+	 *          offline, or @c FALSE if not.
+	 */
 	gboolean (*offline_message)(const PurpleBuddy *buddy);
 
 	PurpleWhiteboardPrplOps *whiteboard_prpl_ops;


More information about the Commits mailing list