im.pidgin.cpw.resiak.disconnectreason: ed001cc919cd5e248ef091feea4b0afd060d8585

[resiak at soc.pidgin.im]

-----------------------------------------------------------------
Revision: ed001cc919cd5e248ef091feea4b0afd060d8585
Ancestor: 5e1647d093114a58682f9cc786a2d8b78cd04999
Author: resiak at soc.pidgin.im
Date: 2007-10-28T16:43:16
Branch: im.pidgin.cpw.resiak.disconnectreason

Modified files:
        ChangeLog.API pidgin/gtkblist.h

ChangeLog: 

Deprecate pidgin_blist_update_account_error_state() and
PidginBuddyList.connection_errors; update ChangeLog.API.

-------------- next part --------------
============================================================
--- ChangeLog.API	22f7d6e3549a7a76c0159e102f4f9f8c16749b4b
+++ ChangeLog.API	e740ffd3542f04b371ec742d375d93dc7f99e43a
@@ -32,6 +32,8 @@ version 2.3.0 (??/??/????):
 		  to whether automatic reconnection should be attempted
 		  after a connection error (rather than checking
 		  gc->wants_to_die).
+		* PurpleConnectionErrorPair, a struct to hold a
+		  PurpleConnectionError and a const char *description.
 		* purple_account_get_current_error() to get the most recent
 		  PurpleConnectionError and description (or NULL if the
 		  account is happy with life), to allow bits of the UI to know
@@ -109,6 +111,10 @@ version 2.3.0 (??/??/????):
 		* purple_request_ok_cancel()
 		* purple_request_yes_no()
 
+		* purple_connection_error()
+		* pidgin_blist_update_account_error_state()
+		* PidginBuddyList.connection_errors
+
 		MSN:
 		* A new independant status type with PURPLE_STATUS_TUNE primitive, and
 		  PURPLE_TUNE_ARTIST, PURPLE_TUNE_ALBUM and PURPLE_TUNE_TITLE
============================================================
--- pidgin/gtkblist.h	cfb4bbe37ca8b200f5d8cb8b7fb08ad137381222
+++ pidgin/gtkblist.h	f688dd28ed3f798d1e3d3de35f588963685a29f8
@@ -84,7 +84,14 @@ struct _PidginBuddyList {
 	GtkWidget *menutray;            /**< The menu tray widget. */
 	GtkWidget *menutrayicon;        /**< The menu tray icon. */
 
-	GHashTable *connection_errors;  /**< Caches connection error messages and accounts. */
+	/** Caches connection error messages; keys are #PurpleAccount and
+	 *  values are non- at c NULL <tt>const char *</tt>s containing localised
+	 *  error messages.  (If an account does not have an error, it will not
+	 *  appear in the table.)
+	 *  @deprecated in favour of purple_account_get_current_error(), which also
+	 *              gives you the #PurpleConnectionError value.
+	 */
+	GHashTable *connection_errors;
 
 	guint refresh_timer;            /**< The timer for refreshing every 30 seconds */
 
@@ -339,13 +346,16 @@ void pidgin_append_blist_node_extended_m
 void pidgin_append_blist_node_extended_menu(GtkWidget *menu, PurpleBlistNode *node);
 
 /**
- * Used by the connection API to tell the blist if an account
- * has a connection error or no longer has a connection error.
+ * Was used by the connection API to tell the blist if an account has a
+ * connection error or no longer has a connection error, but the blist now does
+ * this itself with the @ref account-error-changed signal.
  *
  * @param account The account that either has a connection error
  *        or no longer has a connection error.
  * @param message The connection error message, or NULL if this
  *        account is no longer in an error state.
+ * @deprecated There was no good reason for code other than gtkconn to call
+ *             this.
  */
 void pidgin_blist_update_account_error_state(PurpleAccount *account, const char *message);