im.pidgin.pidgin: 4de61f8b3a8d60c481d7effd1bdf116dff3a405b
datallah at pidgin.im
datallah at pidgin.im
Tue Oct 30 00:30:42 EDT 2007
-----------------------------------------------------------------
Revision: 4de61f8b3a8d60c481d7effd1bdf116dff3a405b
Ancestor: 41094da072afab652217343e975123768e7f797b
Author: datallah at pidgin.im
Date: 2007-10-30T04:28:31
Branch: im.pidgin.pidgin
Modified files:
pidgin/gtkpluginpref.c pidgin/gtkpounce.c pidgin/gtkprefs.c
pidgin/gtksavedstatuses.c pidgin/gtkutils.c
pidgin/plugins/contact_priority.c
pidgin/plugins/gevolution/new_person_dialog.c
pidgin/plugins/pidginrc.c pidgin/plugins/spellchk.c
pidgin/plugins/xmppconsole.c
ChangeLog:
Fix some leaking GtkSizeGroups.
-------------- next part --------------
============================================================
--- pidgin/gtkpluginpref.c bfffd0a0b0b86eaa8c8b10ccd824291463cf4c8a
+++ pidgin/gtkpluginpref.c a221156103f4a075f38e544fa2026ddf88774c1f
@@ -255,5 +255,7 @@ pidgin_plugin_pref_create_frame(PurplePl
}
}
+ g_object_unref(sg);
+
return ret;
}
============================================================
--- pidgin/gtkpounce.c e5ae40b73ce636c72606575619d380f6907f168b
+++ pidgin/gtkpounce.c 553cab9e3d9ce17dee37ec24f7a7af1e8a671029
@@ -685,6 +685,8 @@ pidgin_pounce_editor_show(PurpleAccount
gtk_widget_set_sensitive(dialog->play_sound_browse, FALSE);
gtk_widget_set_sensitive(dialog->play_sound_test, FALSE);
+ g_object_unref(sg);
+
sg = gtk_size_group_new(GTK_SIZE_GROUP_VERTICAL);
gtk_size_group_add_widget(sg, dialog->open_win);
gtk_size_group_add_widget(sg, dialog->popup);
@@ -697,6 +699,9 @@ pidgin_pounce_editor_show(PurpleAccount
gtk_size_group_add_widget(sg, dialog->play_sound_browse);
gtk_size_group_add_widget(sg, dialog->play_sound_test);
+ g_object_unref(sg);
+ sg = NULL;
+
gtk_table_attach(GTK_TABLE(table), dialog->open_win, 0, 1, 0, 1,
GTK_FILL, 0, 0, 0);
gtk_table_attach(GTK_TABLE(table), dialog->popup, 0, 1, 1, 2,
============================================================
--- pidgin/gtkprefs.c a9317dcb31d0d73bb1ed140f83f209c1657acc21
+++ pidgin/gtkprefs.c d484b2baaf83d4415c765c286227abaf9fda4a0b
@@ -956,6 +956,7 @@ interface_page()
g_list_free(names);
gtk_widget_show_all(ret);
+ g_object_unref(sg);
return ret;
}
@@ -1131,7 +1132,7 @@ network_page()
GtkWidget *ret;
GtkWidget *vbox, *hbox, *entry;
GtkWidget *table, *label, *auto_ip_checkbox, *ports_checkbox, *spin_button;
- GtkWidget *warning, *proxy_button;
+ GtkWidget *warning = NULL, *proxy_button = NULL;
GtkSizeGroup *sg;
PurpleProxyInfo *proxy_info = NULL;
@@ -1194,6 +1195,8 @@ network_page()
g_signal_connect(G_OBJECT(auto_ip_checkbox), "clicked",
G_CALLBACK(pidgin_toggle_sensitive), table);
+ g_object_unref(sg);
+
vbox = pidgin_make_frame (ret, _("Ports"));
sg = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
@@ -1337,12 +1340,13 @@ network_page()
}
gtk_widget_show_all(ret);
+ g_object_unref(sg);
/* Only hide table if not running gnome otherwise we hide the IP address table! */
if (!purple_running_gnome() && (proxy_info == NULL ||
purple_proxy_info_get_type(proxy_info) == PURPLE_PROXY_NONE ||
purple_proxy_info_get_type(proxy_info) == PURPLE_PROXY_USE_ENVVAR)) {
gtk_widget_hide(table);
- } else {
+ } else if (purple_running_gnome()) {
gchar *path;
path = g_find_program_in_path("gnome-network-preferences");
if (path != NULL) {
@@ -1501,6 +1505,7 @@ browser_page()
pidgin_set_accessible_label (entry, label);
gtk_widget_show_all(ret);
+ g_object_unref(sg);
return ret;
}
#endif /*_WIN32*/
@@ -1942,6 +1947,7 @@ sound_page()
gtk_box_pack_start(GTK_BOX(hbox), button, FALSE, FALSE, 1);
gtk_widget_show_all(ret);
+ g_object_unref(sg);
return ret;
}
@@ -2067,6 +2073,7 @@ away_page()
}
gtk_widget_show_all(ret);
+ g_object_unref(sg);
return ret;
}
============================================================
--- pidgin/gtksavedstatuses.c 5351ab24f3d2150c021c31c9017e43fe6df711d9
+++ pidgin/gtksavedstatuses.c 6aaf921f625803b7ef442f351abae0b6b530ebb3
@@ -1292,6 +1292,7 @@ pidgin_status_editor_show(gboolean edit,
G_CALLBACK(status_editor_ok_cb), dialog);
gtk_widget_show_all(win);
+ g_object_unref(sg);
}
@@ -1621,6 +1622,7 @@ edit_substatus(StatusEditor *status_edit
}
gtk_widget_show_all(win);
+ g_object_unref(sg);
}
============================================================
--- pidgin/gtkutils.c 81bc86cd23af94f421e9ce23a59378e1c2845921
+++ pidgin/gtkutils.c c3090a879293c78931f251c6ce385de436fc90a2
@@ -2992,6 +2992,8 @@ void *pidgin_make_mini_dialog(PurpleConn
}
va_end(args);
+ g_object_unref(sg);
+
return vbox;
}
============================================================
--- pidgin/plugins/contact_priority.c 721fbac5882c60b779dcb13ea46a6d2ed83bfaa1
+++ pidgin/plugins/contact_priority.c 6d86f63cd3b34b88c5b78213b3a1be67cf3bf2fe
@@ -157,6 +157,7 @@ get_config_frame(PurplePlugin *plugin)
gtk_box_pack_start(GTK_BOX(hbox), spin, FALSE, FALSE, 0);
gtk_widget_show_all(ret);
+ g_object_unref(sg);
return ret;
}
============================================================
--- pidgin/plugins/gevolution/new_person_dialog.c 558974de9d187bc95fdf6e584b5e3ffede277ce1
+++ pidgin/plugins/gevolution/new_person_dialog.c 9bd4deba3fbc490dee8123161a811e891bbe110f
@@ -416,4 +416,6 @@ gevo_new_person_dialog_show(EBook *book,
/* Show it. */
gtk_widget_show(dialog->win);
+ g_object_unref(sg);
+ g_object_unref(sg2);
}
============================================================
--- pidgin/plugins/pidginrc.c 217a3b012ac56e05320357ca3799e47d456cc706
+++ pidgin/plugins/pidginrc.c e11616e622d706c4e5f2ec9d376699a603f4ded7
@@ -509,6 +509,11 @@ purplerc_get_config_frame(PurplePlugin *
G_CALLBACK(purplerc_reread), NULL);
gtk_widget_show_all(ret);
+
+ g_object_unref(labelsg);
+ g_object_unref(widgetsg);
+ g_object_unref(buttonsg);
+
return ret;
}
============================================================
--- pidgin/plugins/spellchk.c 2b350f823dde049d93e0a5fd57bd855e1b1b6fd3
+++ pidgin/plugins/spellchk.c bc5aaaded4722107ea3a5e39f278d32c29c7179e
@@ -2341,6 +2341,8 @@ get_config_frame(PurplePlugin *plugin)
#endif
gtk_widget_show_all(ret);
+ g_object_unref(sg);
+ g_object_unref(sg2);
return ret;
}
============================================================
--- pidgin/plugins/xmppconsole.c 80cff9dcd5c30e00d94c5bc534b75c58de93405c
+++ pidgin/plugins/xmppconsole.c b861b16832614c05125669304d2a3580af55ebf1
@@ -325,8 +325,9 @@ static void iq_clicked_cb(GtkWidget *w,
gtk_text_buffer_get_iter_at_offset(buffer, &iter, strstr(stanza, "</iq>") - stanza);
gtk_text_buffer_place_cursor(buffer, &iter);
g_free(stanza);
-
+
gtk_widget_destroy(dialog);
+ g_object_unref(sg);
}
@@ -483,6 +484,7 @@ static void presence_clicked_cb(GtkWidge
g_free(stanza);
gtk_widget_destroy(dialog);
+ g_object_unref(sg);
}
static void message_clicked_cb(GtkWidget *w, gpointer nul)
@@ -619,6 +621,7 @@ static void message_clicked_cb(GtkWidget
g_free(stanza);
gtk_widget_destroy(dialog);
+ g_object_unref(sg);
}
static void
More information about the Commits
mailing list