im.pidgin.cpw.resiak.disconnectreason: 8182e735afe9772ddf522d11671bb93077b88670

resiak at soc.pidgin.im resiak at soc.pidgin.im
Tue Oct 30 20:35:57 EDT 2007


-----------------------------------------------------------------
Revision: 8182e735afe9772ddf522d11671bb93077b88670
Ancestor: f0cb80a1bc08f9b3e2e63971abe9a4f95a711f6b
Author: resiak at soc.pidgin.im
Date: 2007-10-31T00:32:11
Branch: im.pidgin.cpw.resiak.disconnectreason

Modified files:
        pidgin/gtkutils.h

ChangeLog: 

Improve the documentation of pidgin_make_mini_dialog().

Is it okay to change its return type from void * to GtkWidget * in 2.3, since
that's what it returns, and you have to pass it to pidgin_blist_add_alert()
anyway which expects a GtkWidget *?

-------------- next part --------------
============================================================
--- pidgin/gtkutils.h	e93780a3bb2c8abb288647234a4e37962d0aa1c8
+++ pidgin/gtkutils.h	d57d55835c907195041eb18b37e8feb9986fa983
@@ -600,13 +600,26 @@ char *pidgin_make_pretty_arrows(const ch
 
 /**
  * Creates a "mini-dialog" suitable for embedding in the buddy list scrollbook
+ * with pidgin_blist_add_alert().
  *
- * @param handle         A handle
- * @param stock_id       The ID of a stock image to use in the mini dialog
+ * @param handle         The #PurpleConnection to which this mini-dialog
+ *                       refers, or @c NULL if it does not refer to a
+ *                       connection.  If @a handle is supplied, the mini-dialog
+ *                       will be automatically removed and destroyed when the
+ *                       connection signs off.
+ * @param stock_id       The ID of a stock image to use in the mini dialog.
  * @param primary        The primary text
  * @param secondary      The secondary text
  * @param user_data      Data to pass to the callbacks
- * @param ...            a NULL-terminated list of button labels and callbacks
+ * @param ...            a <tt>NULL</tt>-terminated list of button labels
+ *                       (<tt>char *</tt>) and callbacks, which should take a
+ *                       <tt>void *</tt> argument, as which @a user_data will
+ *                       be passed.  (Strictly speaking a <tt>GtkButton *</tt>
+ *                       will be passed as the second argument, but it can
+ *                       safely be omitted.)
+ * @return               A <tt>GtkWidget *</tt> suitable for passing to
+ *                       pidgin_blist_add_alert().
+ * @see pidginstock.h
  */
 void *pidgin_make_mini_dialog(PurpleConnection *handle, const char* stock_id, 
 				const char *primary, const char *secondary,


More information about the Commits mailing list