pidgin: 1ba0b14b: I've seen intermittent crashes on xmpp f...

evands at pidgin.im evands at pidgin.im
Tue Apr 15 20:05:37 EDT 2008


-----------------------------------------------------------------
Revision: 1ba0b14b585e7117448603344c7363db00d6961b
Ancestor: 46bee021fbbe0ea0cec1a72fe9fcdd885da13dfd
Author: evands at pidgin.im
Date: 2008-04-16T00:01:03
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/1ba0b14b585e7117448603344c7363db00d6961b

Modified files:
        libpurple/protocols/jabber/si.c

ChangeLog: 

I've seen intermittent crashes on xmpp file transfers in this code, but I
haven't been able to figure out the source. This is some debug logging
which will hopefully be illustrative next time someone reports the crash.

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/si.c	840b7c240f9c0f3c0bd1f0ffb2e8792f74d3f1f8
+++ libpurple/protocols/jabber/si.c	4a6b4229f8f4e2f7407f445e96d391470ca07e79
@@ -664,6 +664,9 @@ jabber_si_connect_proxy_cb(JabberStream 
 	if(!(jid = xmlnode_get_attrib(streamhost_used, "jid")))
 		return;
 
+	purple_debug_info("jabber", "jabber_si_connect_proxy_cb() will be looking at jsx %p: jsx->streamhosts is %p and jid is %p",
+					  jsx, jsx->streamhosts, jid);
+
 	if(!(matched = g_list_find_custom(jsx->streamhosts, jid, jabber_si_compare_jid)))
 	{
 		gchar *my_jid = g_strdup_printf("%s@%s/%s", jsx->js->user->node,
@@ -780,6 +783,8 @@ jabber_si_xfer_bytestreams_listen_cb(int
 
 			g_snprintf(port, sizeof(port), "%hu", portnum);
 
+			purple_debug_info("jabber", "jabber_si_xfer_bytestreams_listen_cb() will be looking at jsx %p: jsx->streamhosts %p and ft_proxy_list[%i] %p",
+							  jsx, jsx->streamhosts, i, ft_proxy_list[i]);
 			if(g_list_find_custom(jsx->streamhosts, ft_proxy_list[i], jabber_si_compare_jid) != NULL)
 				continue;
 
@@ -807,6 +812,8 @@ jabber_si_xfer_bytestreams_listen_cb(int
 		if (!(sh->jid && sh->host && sh->port > 0))
 			continue;
 
+		purple_debug_info("jabber", "jabber_si_xfer_bytestreams_listen_cb() will be looking at jsx %p: jsx->streamhosts %p and sh->jid %p",
+						  jsx, jsx->streamhosts, sh->jid);
 		if(g_list_find_custom(jsx->streamhosts, sh->jid, jabber_si_compare_jid) != NULL)
 			continue;
 
@@ -969,6 +976,8 @@ static void jabber_si_xfer_free(PurpleXf
 	g_free(jsx->rxqueue);
 	g_free(jsx);
 	xfer->data = NULL;
+	
+	purple_debug_info("jabber", "jabber_si_xfer_free(): freeing jsx %p", jsx);
 }
 
 static void jabber_si_xfer_cancel_send(PurpleXfer *xfer)


More information about the Commits mailing list