pidgin: b3c7a4b9: Don't try to enable our server-stored bu...

markdoliner at pidgin.im markdoliner at pidgin.im
Wed Apr 16 03:30:44 EDT 2008


-----------------------------------------------------------------
Revision: b3c7a4b983fddcec244f9d9146dccc84651acee8
Ancestor: db28b75aaabae69cf3b4824e98586e7b724ca898
Author: markdoliner at pidgin.im
Date: 2008-04-16T07:25:47
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/b3c7a4b983fddcec244f9d9146dccc84651acee8

Modified files:
        libpurple/protocols/oscar/oscar.c

ChangeLog: 

Don't try to enable our server-stored buddylist if we receive an error
from an ssi snac.  We've been doing this since 2003, and I'm really
not sure why.  I think my original thought was that if we failed to
retrieve our buddy list we could at least communicate with people.

But with the current code we'll try to refetch our buddylist in 30
seconds, so I think it's better to just wait it out.  Plus, I think
you might actually be able to IM people without your buddylist... they
just won't see you online.

-------------- next part --------------
============================================================
--- libpurple/protocols/oscar/oscar.c	8448fa1768017509dd7be0c29b0d1a849b9a5541
+++ libpurple/protocols/oscar/oscar.c	fc455c057ed784ce86fcadcf3d26679ae98673d1
@@ -4790,12 +4790,6 @@ static int purple_ssi_parseerr(OscarData
 
 	oscar_set_extendedstatus(gc);
 
-	/* Activate SSI */
-	/* Sending the enable causes other people to be able to see you, and you to see them */
-	/* Make sure your privacy setting/invisibility is set how you want it before this! */
-	purple_debug_info("oscar", "ssi: activating server-stored buddy list\n");
-	aim_ssi_enable(od);
-
 	return 1;
 }
 


More information about the Commits mailing list