pidgin: d97c43db: Don't assign this stuff in a loop.

qulogic at pidgin.im qulogic at pidgin.im
Fri Aug 8 02:11:18 EDT 2008


-----------------------------------------------------------------
Revision: d97c43db0cb5ad281a1ae355c44fbc7991302b0c
Ancestor: 706e3d696e82d473093c4ca272fb32dc452f3297
Author: qulogic at pidgin.im
Date: 2008-08-04T03:46:33
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/d97c43db0cb5ad281a1ae355c44fbc7991302b0c

Modified files:
        libpurple/protocols/msn/slp.c

ChangeLog: 

Don't assign this stuff in a loop.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/slp.c	7063d56d95066ebfb58e534a5da44636b2177daa
+++ libpurple/protocols/msn/slp.c	397d44a410f4d9299578913240c3c3d50958e5d7
@@ -814,6 +814,9 @@ msn_emoticon_msg(MsnCmdProc *cmdproc, Ms
 	if (!purple_account_get_bool(session->account, "custom_smileys", TRUE))
 		return;
 
+	swboard = cmdproc->data;
+	conv = swboard->conv;
+
 	body = msn_message_get_bin_data(msg, &body_len);
 	body_str = g_strndup(body, body_len);
 
@@ -838,10 +841,7 @@ msn_emoticon_msg(MsnCmdProc *cmdproc, Ms
 		sha1 = msn_object_get_sha1(obj);
 
 		slplink = msn_session_get_slplink(session, who);
-
-		swboard = cmdproc->data;
 		slplink->swboard = swboard;
-		conv = swboard->conv;
 
 		/* If the conversation doesn't exist then this is a custom smiley
 		 * used in the first message in a MSN conversation: we need to create


More information about the Commits mailing list