pidgin: 66d0a80d: It turns out that setting the window tit...

datallah at datallah at
Thu Aug 14 00:40:56 EDT 2008

Revision: 66d0a80d9160a71452ff5c0e192723454da0515e
Ancestor: 5b7ddf456d02b95200e8c1dea2275420068468cf
Author: datallah at
Date: 2008-08-14T04:17:21
Branch: im.pidgin.pidgin

Modified files:


It turns out that setting the window title causes it to stop flashing on win32.
This means that every time we recieve a typing notification event for the
current tab, we lose notification that we have unread messages.  Fortunately,
we can avoid this by checking if we actually need to change the title.
Fixes #1502 (yay!).

-------------- next part --------------
--- pidgin/gtkconv.c	2bc2c412f49993c3919aa616ae250a8e6a0cf70c
+++ pidgin/gtkconv.c	2ba67831f6773420c93bbc89bb0c035b000b08ec
@@ -6604,8 +6604,11 @@ pidgin_conv_update_fields(PurpleConversa
 		gtk_label_set_text(GTK_LABEL(gtkconv->menu_label), title);
-		if (pidgin_conv_window_is_active_conversation(conv))
-			gtk_window_set_title(GTK_WINDOW(win->window), title);
+		if (pidgin_conv_window_is_active_conversation(conv)) {
+			const char* current_title = gtk_window_get_title(GTK_WINDOW(win->window));
+			if (current_title == NULL || strcmp(current_title, title) != 0)
+				gtk_window_set_title(GTK_WINDOW(win->window), title);
+		}

More information about the Commits mailing list