soc.2008.masterpassword: ee254037: Corrected a typo in keyring.c

[scrouaf at soc.pidgin.im]

-----------------------------------------------------------------
Revision: ee254037c9283ad85b45111dd7761e8b86ecda80
Ancestor: 8eeacc790efc6b8f290b558fcc75dc3b5cca2c48
Author: scrouaf at soc.pidgin.im
Date: 2008-08-17T21:30:50
Branch: im.pidgin.soc.2008.masterpassword
URL: http://d.pidgin.im/viewmtn/revision/info/ee254037c9283ad85b45111dd7761e8b86ecda80

Modified files:
        configure.ac libpurple/keyring.c
        libpurple/plugins/keyrings/Makefile.am pidgin/gtkprefs.c

ChangeLog: 

Corrected a typo in keyring.c
Corrected a bug in gtkprefs.c that caused the button sensitivity not be 
updated
Figured out how to do all that configure and makefile stuff properly.
Still have a few warnings when automake is run.

-------------- next part --------------
============================================================
--- configure.ac	57a3bdbf0e6bdc213c69d5c87179abbbc1b5153b
+++ configure.ac	8055ef48c62b00c1ca6be79219a66fc91db97674
@@ -1230,6 +1230,7 @@ AC_ARG_ENABLE(nm, [AC_HELP_STRING([--dis
 
 AC_ARG_ENABLE(dbus, [AC_HELP_STRING([--disable-dbus], [disable D-Bus support])], , enable_dbus=yes)
 AC_ARG_ENABLE(nm, [AC_HELP_STRING([--disable-nm], [disable NetworkManager support (requires D-Bus)])], enable_nm=$enableval, enable_nm=yes)
+AC_ARG_ENABLE(gnome-keyring, [AC_HELP_STRING([--disable-gnome-keyring], [disable Gnome-Keyring support (requires D-Bus)])], enable_gnome_keyring=$enableval, enable_gnome_keyring=yes)
 
 if test "x$enable_dbus" = "xyes" ; then
 	AC_CHECK_PROG(enable_dbus, dbus-binding-tool, yes, no)
@@ -1262,10 +1263,34 @@ Use --disable-nm if you do not need Netw
 ])
 			fi])
 	fi
+
+
+PKG_CHECK_MODULES(GNOMEKEYRING, gnome-keyring-1)
+dnl Check for gnome-keyring.h; if we don't have it, oh well
+	if test "x$enable_gnome_keyring" = "xyes" ; then
+		PKG_CHECK_MODULES(GNOMEKEYRING, [gnome-keyring-1], [
+			AC_SUBST(GNOMEKEYRING_CFLAGS)
+			AC_SUBST(GNOMEKEYRING_LIBS)
+			AC_DEFINE(HAVE_GNOMEKEYRING, 1, [Define if we have Gnome-Keyring.])
+		], [
+			if test "x$force_deps" = "xyes" ; then
+				AC_MSG_ERROR([
+Gnome-Keyring development headers not found.
+Use --disable-gnome-keyring if you do not need Gnome-Keyring support.
+])
+			fi])
+	fi
 else
+	enable_gnome_keyring=no
 	enable_nm=no
 fi
 
+AM_CONDITIONAL(ENABLE_GNOMEKEYRING, test "x$enable_gnome_keyring" = "xyes")
+
+
+
+
+
 dnl #######################################################################
 dnl # Check for Python
 dnl #######################################################################
@@ -2455,6 +2480,7 @@ echo Build with NetworkManager..... : $e
 	eval eval echo D-Bus services directory...... : $DBUS_SERVICES_DIR
 fi
 echo Build with NetworkManager..... : $enable_nm
+echo Build with Gnome-Keyring...... : $enable_gnome_keyring
 echo SSL Library/Libraries......... : $msg_ssl
 if test "x$SSL_CERTIFICATES_DIR" != "x" ; then
 	eval eval echo SSL CA certificates directory. : $SSL_CERTIFICATES_DIR
============================================================
--- libpurple/keyring.c	b0ef204e4a9c3a70fb1cfe46623c6f909a5edc03
+++ libpurple/keyring.c	ff60ee9a8363c4289d22bf6b490fd09342b39261
@@ -1022,7 +1022,7 @@ purple_keyring_set_password_async_cb(Pur
 
 	if (error != NULL) {
 		purple_notify_error(NULL, _("Keyrings"),
-			_("Failed to save password in keyring.")
+			_("Failed to save password in keyring."),
 			error->message);
 	}
 
============================================================
--- libpurple/plugins/keyrings/Makefile.am	d73056f2569849c5c5ee37dd18d2a8fb571fea95
+++ libpurple/plugins/keyrings/Makefile.am	d9be6be91557e74245d6a7dce2bf49ae46d5c303
@@ -3,25 +3,35 @@ plugindir = $(libdir)/purple-$(PURPLE_MA
 
 plugindir = $(libdir)/purple-$(PURPLE_MAJOR_VERSION)
 
+
+if ENABLE_GNOMEKEYRING
+
 gnomekeyring_la_LDFLAGS     = -module -avoid-version
-internalkeyring_la_LDFLAGS  = -module -avoid-version
+GKRSOURCES = gnomekeyring.c
+#GNOME_KEYRING_CFLAGS = -I/usr/include/gnome-keyring-1
+#GNOME_KEYRING_LIBS   = -lgnome-keyring
+GNOME_KEYRING_LA = internalkeyring.la
 
-GNOME_KEYRING_CFLAGS = -I/usr/include/gnome-keyring-1
-GNOME_KEYRING_LIBS   = -lgnome-keyring
+endif #ENABLE_GNOMEKEYRING
 
-GKRSOURCES = gnomekeyring.c
+internalkeyring_la_LDFLAGS  = -module -avoid-version
 IKSOURCES = internalkeyring.c
 
 if PLUGINS
 
 plugin_LTLIBRARIES = \
-	gnomekeyring.la       \
+	$(GNOME_KEYRING_LA)\
 	internalkeyring.la
 
-gnomekeyring_la_SOURCES     = gnomekeyring.c
-internalkeyring_la_SOURCES  = internalkeyring.c
 
-gnomekeyring_la_LIBADD  = $(GLIB_LIBS) $(GNOME_KEYRING_LIBS)
+if ENABLE_GNOMEKEYRING
+
+gnomekeyring_la_SOURCES     = $(GKRSOURCES)
+gnomekeyring_la_LIBADD  = $(GLIB_LIBS) $(GNOMEKEYRING_LIBS)
+
+endif #ENABLE_GNOMEKEYRING
+
+internalkeyring_la_SOURCES  = $(IKSOURCES)
 internalkeyring_la_LIBADD   = $(GLIB_LIBS)
 
 endif #PLUGINS
@@ -34,7 +44,9 @@ AM_CPPFLAGS = \
 	$(PLUGIN_CFLAGS) \
 	$(GNOME_KEYRING_CFLAGS)
 
-gnomekeyring_la_CFLAGS = $(AM_CPPFLAGS) $(GNOME_KEYRING_CFLAGS)
+if ENABLE_GNOMEKEYRING
+gnomekeyring_la_CFLAGS = $(AM_CPPFLAGS) $(GNOMEKEYRING_CFLAGS)
+endif #ENABLE_GNOMEKEYRING
 internalkeyring_la_CFLAGS = $(AM_CPPFLAGS)
 
 
============================================================
--- pidgin/gtkprefs.c	c60ca6d9c030bed077735d3318093cb779bbbe4c
+++ pidgin/gtkprefs.c	06c730af8399222239fba8b36110f473db7bebc9
@@ -1645,7 +1645,7 @@ keyring_page_pref_changed(const char *na
 	PurpleKeyring * keyring;
 
 	g_return_if_fail(type == PURPLE_PREF_STRING);
-	g_return_if_fail(g_strcmp0(val,"/purple/keyring/active") == 0);
+	g_return_if_fail(g_strcmp0(name,"/purple/keyring/active") == 0);
 
 	/**
 	 * This part is annoying.
@@ -1654,6 +1654,7 @@ keyring_page_pref_changed(const char *na
 	 * have to rely on the prefs system, and find the keyring that
 	 * is (or will be) used, from there.
 	 */
+
 	keyring = purple_keyring_get_keyring_by_id(val);
 
 	if (purple_keyring_get_change_master(keyring))