pidgin: ba3f723f: Close notify and request dialogs with Pu...

qulogic at qulogic at
Sun Aug 17 21:10:43 EDT 2008

Revision: ba3f723f019f6c1c357377d8173ba7823823f9c7
Ancestor: 839b5333f46e3df6e9893b81ccfc124324586fe4
Author: qulogic at
Date: 2008-08-18T01:00:58
Branch: im.pidgin.pidgin

Modified files:


Close notify and request dialogs with PurpleSslConnection as handle. 
This fixes crashes with the Accept/Reject Certificate dialog after an
account is disabled. It only works because the NSS and GnuTLS plugins 
pass the sslconn as their callback data, and the certificate code uses 
that data as the handle. Not sure, but I still think this will leak 
PurpleCertificateVerificationRequest's though because there doesn't 
seem to be anyone hanging on to them.

-------------- next part --------------
--- libpurple/sslconn.c	aa0aadcf087d62dec198fba7973f98bc3bc365b0
+++ libpurple/sslconn.c	2d3ba35764808ce88b5379ada27b2706e2996288
@@ -27,6 +27,7 @@
 #include "certificate.h"
 #include "debug.h"
+#include "request.h"
 #include "sslconn.h"
 static gboolean _ssl_initialized = FALSE;
@@ -227,6 +228,9 @@ purple_ssl_close(PurpleSslConnection *gs
 	g_return_if_fail(gsc != NULL);
+	purple_request_close_with_handle(gsc);
+	purple_notify_close_with_handle(gsc);
 	ops = purple_ssl_get_ops();

More information about the Commits mailing list