soc.2008.yahoo: f9ab6a93: Remove bug that crashed pidgin when send...

sulabh at soc.pidgin.im sulabh at soc.pidgin.im
Fri Aug 22 15:30:31 EDT 2008


-----------------------------------------------------------------
Revision: f9ab6a93c8e81fcac0c6a4a4dd49ebd888596a5d
Ancestor: f8b6e98d7e316ff58d4dc4bd6f376835dbd918ce
Author: sulabh at soc.pidgin.im
Date: 2008-08-22T19:27:31
Branch: im.pidgin.soc.2008.yahoo
URL: http://d.pidgin.im/viewmtn/revision/info/f9ab6a93c8e81fcac0c6a4a4dd49ebd888596a5d

Modified files:
        libpurple/protocols/yahoo/yahoo.c

ChangeLog: 

Remove bug that crashed pidgin when sending p2p pkt to a buddy not on 
server list

-------------- next part --------------
============================================================
--- libpurple/protocols/yahoo/yahoo.c	f78ef4a83c46b380f14b317139ad8bf9ff68220e
+++ libpurple/protocols/yahoo/yahoo.c	9c8b0925999dd7c05d29851cea2e135cd5ef2c72
@@ -2642,12 +2642,12 @@ void yahoo_send_p2p_pkt(PurpleConnection
 	if( strcmp(purple_normalize(account, purple_account_get_username(account)), who) == 0)
 		return;
 
-	/* Dont send p2p packet to buddies of other protocols */
-	if(f->protocol)
+	/* send packet to only those friends who arent p2p connected and to whom we havent already sent. Do not send if this condition doesn't hold good */ 
+	if( !( f && (yahoo_friend_get_p2p_status(f) == YAHOO_P2PSTATUS_NOT_CONNECTED) && (f->p2p_packet_sent == 0)) )
 		return;
 
-	/* send packet to only those friends who arent p2p connected and to whom we havent already sent. Do not send if this condition doesn't hold good */ 
-	if( !( f && (yahoo_friend_get_p2p_status(f) == YAHOO_P2PSTATUS_NOT_CONNECTED) && (f->p2p_packet_sent == 0)) )
+	/* Dont send p2p packet to buddies of other protocols */
+	if(f->protocol)
 		return;
 
 	public_ip = purple_network_get_public_ip();


More information about the Commits mailing list