pidgin: dd7a36be: Add a debug line and remove a duplicate ...

markdoliner at markdoliner at
Fri Dec 5 20:40:44 EST 2008

Revision: dd7a36be12180dba9663c2b740553e89711d7644
Ancestor: a1ad9ab6671970d851852ea29ac86fbd0b43a2f2
Author: markdoliner at
Date: 2008-12-06T01:38:48
Branch: im.pidgin.pidgin

Modified files:


Add a debug line and remove a duplicate "login=" get parameter which
was causing yahoo's servers to give us an HTTP 400 error, which is
technically probably not valid according to http 1.1

-------------- next part --------------
--- libpurple/protocols/yahoo/yahoo.c	52e72503825182377c124651a20dd661861abbcc
+++ libpurple/protocols/yahoo/yahoo.c	859ba7874df76a1c81b7bb8f22101aac285daea1
@@ -2706,6 +2706,7 @@ static void yahoo_web_pending(gpointer d
 			  strncmp(buf, "HTTP/1.1 302", strlen("HTTP/1.1 302")))) {
 		purple_connection_error_reason(gc, PURPLE_CONNECTION_ERROR_NETWORK_ERROR,
 			_("Received unexpected HTTP response from server."));
+		purple_debug_misc("yahoo", "Unexpected HTTP response: %s\n", buf);
@@ -2802,7 +2803,7 @@ static void yahoo_login_page_hash_iter(c
 static void yahoo_login_page_hash_iter(const char *key, const char *val, GString *url)
-	if (!strcmp(key, "passwd"))
+	if (!strcmp(key, "passwd") || !strcmp(key, "login"))
 	g_string_append_c(url, '&');
 	g_string_append(url, key);

More information about the Commits mailing list