pidgin: 504bd11e: I think we don't need to keep track of t...

qulogic at pidgin.im qulogic at pidgin.im
Wed Dec 10 01:55:56 EST 2008


-----------------------------------------------------------------
Revision: 504bd11eb0160511a68c8c123ce55505fe843669
Ancestor: e5b0753145f1d3c56ef6da9fa5dcf398a67b01da
Author: qulogic at pidgin.im
Date: 2008-12-08T00:18:45
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/504bd11eb0160511a68c8c123ce55505fe843669

Modified files:
        libpurple/protocols/msn/msn.c
        libpurple/protocols/msn/userlist.c
        libpurple/protocols/msn/userlist.h

ChangeLog: 

I think we don't need to keep track of the number of users on the FL. This
stuff has been commented out for a while now, with no complaints. Whatever the
limit is now, it's either reported by the server, or too large for anyone to
care, it seems.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/msn.c	123777da3af7dd12810bf2a41aa2e1e909c98720
+++ libpurple/protocols/msn/msn.c	4ecabb8b941efd28b7e8126b64d979b7d11df6e6
@@ -1443,17 +1443,6 @@ msn_add_buddy(PurpleConnection *gc, Purp
 		purple_debug_info("msn", "msn_add_buddy: %s\n", who);
 #endif
 
-#if 0
-	/* Which is the max? */
-	if (session->fl_users_count >= 150)
-	{
-		purple_debug_info("msn", "Too many buddies\n");
-		/* Buddy list full */
-		/* TODO: purple should be notified of this */
-		return;
-	}
-#endif
-
 	/* XXX - Would group ever be NULL here?  I don't think so...
 	 * shx: Yes it should; MSN handles non-grouped buddies, and this is only
 	 * internal. */
============================================================
--- libpurple/protocols/msn/userlist.c	5f042776a973d40096a62a1f66f1974ad9450981
+++ libpurple/protocols/msn/userlist.c	aff6480b441c82e9523b85471bd5ceaf88922a2c
@@ -184,10 +184,6 @@ msn_got_add_user(MsnSession *session, Ms
 		{
 			msn_user_add_group_id(user, group_id);
 		}
-		else
-		{
-			/* session->sync->fl_users_count++; */
-		}
 	}
 	else if (list_id == MSN_LIST_AL)
 	{
@@ -253,10 +249,6 @@ msn_got_rem_user(MsnSession *session, Ms
 			msn_user_remove_group_id(user, group_id);
 			return;
 		}
-		else
-		{
-			/* session->sync->fl_users_count--; */
-		}
 	}
 	else if (list_id == MSN_LIST_AL)
 	{
============================================================
--- libpurple/protocols/msn/userlist.h	d13c4944c5797017c7d5a6108417c212935406ef
+++ libpurple/protocols/msn/userlist.h	0969c0a68d870f89e8868e85bbcf2a99d556b429
@@ -53,8 +53,6 @@ struct _MsnUserList
 	int buddy_icon_window;
 	guint buddy_icon_request_timer;
 
-	int fl_users_count;
-
 };
 
 gboolean msn_userlist_user_is_in_group(MsnUser *user, const char * group_id);


More information about the Commits mailing list