pidgin: 895d2560: Fix a crash in DNS SRV resolution when o...

[rekkanoryo at pidgin.im]

-----------------------------------------------------------------
Revision: 895d2560a5074216c9dc0a7a0ac718790710b8d1
Ancestor: 23ad404d0d25182520679ac9d4ab4c7517766f04
Author: florian at instantbird.org
Date: 2008-12-15T04:02:28
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/895d2560a5074216c9dc0a7a0ac718790710b8d1

Modified files:
        ChangeLog libpurple/dnssrv.c

ChangeLog: 

Fix a crash in DNS SRV resolution when one of the required parameters is NULL.
Fixes #7765.

-------------- next part --------------
============================================================
--- ChangeLog	196c4b9d58cba9489cf02e7e31735a42356db8cb
+++ ChangeLog	040c3b363208fb520572a60331105084a2163d9b
@@ -21,6 +21,7 @@ version 2.5.3 (12/??/2008):
 	  (Jarom?r Karmaz?n)
 	* Many QQ fixes and improvements, including the ability to connect
 	  using QQ2008 protocol and sending/receiving of long messages.
+	* Fix a crash with DNS SRV lookups (Florian Qu?ze)
 
 	Gadu-Gadu:
 	* Fix some problems with Gadu-Gadu buddy icons (Adam Strzelecki)
============================================================
--- libpurple/dnssrv.c	b27bf5a97d652bb86861f274528bba2a355f3384
+++ libpurple/dnssrv.c	b5d8ba690b4cdc4f2de4058ffb867619caa81328
@@ -336,6 +336,12 @@ purple_srv_resolve(const char *protocol,
 	static gboolean initialized = FALSE;
 #endif
 
+	if (!protocol || !*protocol || !transport || !*transport || !domain || !*domain) {
+		purple_debug_error("dnssrv", "Wrong arguments\n");
+		cb(NULL, 0, extradata);
+		g_return_val_if_reached(NULL);
+	}
+
 	query = g_strdup_printf("_%s._%s.%s", protocol, transport, domain);
 	purple_debug_info("dnssrv","querying SRV record for %s\n", query);