pidgin: 724fba52: Fix a leak "KuSh" discovered using "cppc...

datallah at pidgin.im datallah at pidgin.im
Mon Dec 22 12:05:55 EST 2008


-----------------------------------------------------------------
Revision: 724fba520cfff8d0db07424c911a91b93d0cf0ad
Ancestor: bc05f646734142ed0e42f34e38436168db5c6d9c
Author: datallah at pidgin.im
Date: 2008-12-22T16:22:08
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/724fba520cfff8d0db07424c911a91b93d0cf0ad

Modified files:
        libpurple/protocols/qq/group_internal.c

ChangeLog: 

Fix a leak "KuSh" discovered using "cppcheck". Fixes #7859.

-------------- next part --------------
============================================================
--- libpurple/protocols/qq/group_internal.c	0c1a9a139300f02d86f979b5ab665e2e17f8b255
+++ libpurple/protocols/qq/group_internal.c	df41b2a15e9ad3cb4dcdb04a3255071d0074e13e
@@ -30,7 +30,7 @@
 #include "group_internal.h"
 #include "utils.h"
 
-static qq_room_data *room_data_new(guint32 id, guint32 ext_id, gchar *title)
+static qq_room_data *room_data_new(guint32 id, guint32 ext_id, const gchar *title)
 {
 	qq_room_data *rmd;
 
@@ -62,9 +62,9 @@ static qq_room_data *room_data_new_by_ha
 
 	value = g_hash_table_lookup(data, QQ_ROOM_KEY_INTERNAL_ID);
 	id = value ? strtoul(value, NULL, 10) : 0;
-	value= g_hash_table_lookup(data, QQ_ROOM_KEY_EXTERNAL_ID);
+	value = g_hash_table_lookup(data, QQ_ROOM_KEY_EXTERNAL_ID);
 	ext_id = value ? strtoul(value, NULL, 10) : 0;
-	value = g_strdup(g_hash_table_lookup(data, QQ_ROOM_KEY_TITLE_UTF8));
+	value = g_hash_table_lookup(data, QQ_ROOM_KEY_TITLE_UTF8);
 
 	rmd = room_data_new(id, ext_id, value);
 	rmd->my_role = QQ_ROOM_ROLE_YES;


More information about the Commits mailing list