cpw.malu.xmpp.idle: d997bb64: Added comment about eventually needing a...

malu at pidgin.im malu at pidgin.im
Wed Dec 24 08:41:30 EST 2008

Revision: d997bb64d86eafc69762eb4592fcf53302681eaf
Ancestor: 1b3803205751116ec2a71e0752abee12894b60e7
Author: malu at pidgin.im
Date: 2008-12-24T13:36:10
Branch: im.pidgin.cpw.malu.xmpp.idle
URL: http://d.pidgin.im/viewmtn/revision/info/d997bb64d86eafc69762eb4592fcf53302681eaf

Modified files:


Added comment about eventually needing a way to distinguish intial presence
received upon logging in (to be able to disregard idle time when there is no
delayed element on an initial presence, in which case we don't know when the
buddy became idle).

-------------- next part --------------
--- libpurple/protocols/jabber/presence.c	1d936aa57758d85799aa4df771c76b7409e8891b
+++ libpurple/protocols/jabber/presence.c	f51385971e971475dcdb991321227c472c9d2d47
@@ -424,6 +424,11 @@ static void jabber_presence_set_capabili
+/* would need to add some detection to determine if a
+ <presence/> packet is part of the "initial" presence the server
+ sends us, this way we could disregard a buddy's idle time in case the server
+ does not set <delayed/> on delayed presence. This would avoid 
+ showing an incorrect idle time */
 void jabber_presence_parse(JabberStream *js, xmlnode *packet)
 	const char *from = xmlnode_get_attrib(packet, "from");

More information about the Commits mailing list