cpw.malu.xmpp.idle: 7a22c71f: Updated a comment to describe what the a...

malu at pidgin.im malu at pidgin.im
Thu Dec 25 08:26:34 EST 2008

Revision: 7a22c71f42efc42841fcfefd5dd77c36ca0d2b37
Ancestor: a7ec91e9a7e4f8692b23cf175956183f84f0d198
Author: malu at pidgin.im
Date: 2008-12-25T13:21:27
Branch: im.pidgin.cpw.malu.xmpp.idle
URL: http://d.pidgin.im/viewmtn/revision/info/7a22c71f42efc42841fcfefd5dd77c36ca0d2b37

Modified files:


Updated a comment to describe what the actually does
Removed a comment about initial presence

-------------- next part --------------
--- libpurple/protocols/jabber/buddy.c	4c60928410c25cfe853635bb38f740e8afb5e5d6
+++ libpurple/protocols/jabber/buddy.c	44a6fb2e5bf254fb854299ecdf6bbd620704a7d7
@@ -1638,10 +1638,9 @@ static void jabber_last_parse(JabberStre
 							jbir->idle_seconds = sec;
-                    /* if this idle time different from the one stored
-                     in the JabberBuddyResource (as obtained via
-                     <presence/>) update it. This is to correct the value
-                     when a server doesn't mark delayed presence */
+                    /* Update the idle time of the buddy resource, if we got it. 
+                     This will correct the value when a server doesn't mark 
+                     delayed presence and we got the presence when signing on */
                     jb = jabber_buddy_find(js, from, FALSE);
                     if (jb) {
                         resource = jabber_get_resource(from);
--- libpurple/protocols/jabber/presence.c	f51385971e971475dcdb991321227c472c9d2d47
+++ libpurple/protocols/jabber/presence.c	1d936aa57758d85799aa4df771c76b7409e8891b
@@ -424,11 +424,6 @@ static void jabber_presence_set_capabili
-/* would need to add some detection to determine if a
- <presence/> packet is part of the "initial" presence the server
- sends us, this way we could disregard a buddy's idle time in case the server
- does not set <delayed/> on delayed presence. This would avoid 
- showing an incorrect idle time */
 void jabber_presence_parse(JabberStream *js, xmlnode *packet)
 	const char *from = xmlnode_get_attrib(packet, "from");

More information about the Commits mailing list