im.pidgin.pidgin: a5456268d56c1a4745ac4abb84a176ecc6f68109

evands at pidgin.im evands at pidgin.im
Mon Jan 7 21:50:39 EST 2008


-----------------------------------------------------------------
Revision: a5456268d56c1a4745ac4abb84a176ecc6f68109
Ancestor: 6227c43549bf66022512f18bb36d70b7c57c4430
Author: evands at pidgin.im
Date: 2008-01-08T02:47:51
Branch: im.pidgin.pidgin

Modified files:
        libpurple/buddyicon.c

ChangeLog: 

There's nothing wrong with calling purple_buddy_icons_find() can not receiving an icon in return - it just means that no icon was found.  We shouldn't attempt to call purple_buddy_icon_ref() on NULL, which will trigger a failed assertion.

-------------- next part --------------
============================================================
--- libpurple/buddyicon.c	e194ec393e3246d69d5a1dc7b0b3c1f911170c40
+++ libpurple/buddyicon.c	a73df57ec69cebed25d67518c291fe548c233eed
@@ -625,7 +625,7 @@ purple_buddy_icons_find(PurpleAccount *a
 		purple_buddy_icons_set_caching(caching);
 	}
 
-	return purple_buddy_icon_ref(icon);
+	return (icon ? purple_buddy_icon_ref(icon) : nil);
 }
 
 gboolean


More information about the Commits mailing list