im.pidgin.pidgin: cd29baac3f6b045ec50d2511b143b39f8884b36d

markdoliner at pidgin.im markdoliner at pidgin.im
Thu Jan 17 02:55:50 EST 2008


-----------------------------------------------------------------
Revision: cd29baac3f6b045ec50d2511b143b39f8884b36d
Ancestor: 2686355efa35ffd45699ee70fab20885424e502b
Author: markdoliner at pidgin.im
Date: 2008-01-17T07:53:03
Branch: im.pidgin.pidgin

Modified files:
        libpurple/protocols/oscar/oscar.c

ChangeLog: 

Apparently gcc gives a warning here even though it's perfectly valid
and more efficient.

-------------- next part --------------
============================================================
--- libpurple/protocols/oscar/oscar.c	4ada101981c24b2cebd86e0287df955074e3d373
+++ libpurple/protocols/oscar/oscar.c	3e5cd2f1195c4b2edd275463fb4d67b3e3406892
@@ -1789,11 +1789,7 @@ static int purple_parse_oncoming(OscarDa
 		purple_prpl_got_user_status_deactive(account, info->sn, OSCAR_STATUS_ID_MOBILE);
 	}
 
-	/*
-	 * It's ok for us to use == instead of strcmp() here because
-	 * status_id is set to one of these #defines a few lines above here.
-	 */
-	if (status_id == OSCAR_STATUS_ID_AVAILABLE)
+	if (strcmp(status_id, OSCAR_STATUS_ID_AVAILABLE) == 0)
 	{
 		char *message = NULL;
 		char *itmsurl = NULL;


More information about the Commits mailing list