im.pidgin.pidgin: ba2fcd0ff9b6309bdae42ab4c25a628916a5cb6c

markdoliner at pidgin.im markdoliner at pidgin.im
Thu Jan 31 21:55:53 EST 2008


-----------------------------------------------------------------
Revision: ba2fcd0ff9b6309bdae42ab4c25a628916a5cb6c
Ancestor: 8a2bc1c107dda03be697372ac062883e4e931b72
Author: markdoliner at pidgin.im
Date: 2008-02-01T02:53:51
Branch: im.pidgin.pidgin

Modified files:
        libpurple/protocols/yahoo/yahoo.c

ChangeLog: 

Our Yahoo! protocol has this crappy implementation where it tries
to do something clever with the permit/deny setting.

Here's how it works:
* Yahoo! has only a "deny" list
* libpurple keeps a copy of this "deny" list
* If you change your permdeny setting to "allow all" or "permit only
  these users" then the Yahoo! PRPL unblocks everyone
  on your deny list
* If you change your permdeny setting to "allow people in my buddylist"
  or "block this people below" then the Yahoo! PRPL re-blocks the people
  in your deny list.

This commit changes that behavior slightly.  If you set your permdeny
setting to "permit only these users" or "block everyone" then the
Yahoo! PRPL will now re-block the people in your deny list.

-------------- next part --------------
============================================================
--- libpurple/protocols/yahoo/yahoo.c	9f1a20674a28da90cf9e269d5a912bde0fdff9b6
+++ libpurple/protocols/yahoo/yahoo.c	cd482c6914ef3824dcaac891df6cb36009f9b46e
@@ -3950,20 +3950,17 @@ static void yahoo_set_permit_deny(Purple
 	switch (account->perm_deny)
 	{
 		case PURPLE_PRIVACY_ALLOW_ALL:
-		case PURPLE_PRIVACY_ALLOW_USERS:
 			for (deny = account->deny; deny; deny = deny->next)
 				yahoo_rem_deny(gc, deny->data);
 			break;
 
 		case PURPLE_PRIVACY_ALLOW_BUDDYLIST:
+		case PURPLE_PRIVACY_ALLOW_USERS:
 		case PURPLE_PRIVACY_DENY_USERS:
+		case PURPLE_PRIVACY_DENY_ALL:
 			for (deny = account->deny; deny; deny = deny->next)
 				yahoo_add_deny(gc, deny->data);
 			break;
-
-		case PURPLE_PRIVACY_DENY_ALL:
-		default:
-			break;
 	}
 }
 


More information about the Commits mailing list