pidgin: 2b441ba9: Remove a failsafe check that I don't bel...

markdoliner at markdoliner at
Mon Jul 7 21:00:44 EDT 2008

Revision: 2b441ba99ecbf84cdadb1490a51f92857dda488c
Ancestor: 8f5cce1d7904eacfae6731e702c4908c904a881e
Author: markdoliner at
Date: 2008-07-08T00:58:21
Branch: im.pidgin.pidgin

Modified files:


Remove a failsafe check that I don't believe is needed.  I'm under the
impression that sometimes the last modified timestamp will (at least
somewhat) legitimately be set to 0 in cases where we really have
received our roster.

And this function doesn't seem to get called when we haven't received
our roster.

So, uh, this should fix the aim buddylist for a very small fraction of
users who probably gave up on using Pidgin when it didn't work for
them the first time they tried.

-------------- next part --------------
--- libpurple/protocols/oscar/oscar.c	a9f89c1222ef8826b9782b2da56cb738763ea62a
+++ libpurple/protocols/oscar/oscar.c	5f76ec30a2890b09fcf695e155ec2cedef352c7a
@@ -4928,11 +4928,6 @@ static int purple_ssi_parselist(OscarDat
 			   "ssi: syncing local list and server list\n");
-	if ((timestamp == 0) || (numitems == 0)) {
-		purple_debug_info("oscar", "Got AIM SSI with a 0 timestamp or 0 numitems--not syncing.  This probably means your buddy list is empty.\n");
-		return 1;
-	}
 	/* Clean the buddy list */

More information about the Commits mailing list