pidgin: 42c78102: On MSN, when an error occurs when openin...

qulogic at pidgin.im qulogic at pidgin.im
Mon Jul 14 01:00:43 EDT 2008


-----------------------------------------------------------------
Revision: 42c781022327add4641b756f0a78587ef3ce2d1a
Ancestor: 816df2e8ea378089324051a96496f48ad4497e5f
Author: qulogic at pidgin.im
Date: 2008-07-14T04:55:34
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/42c781022327add4641b756f0a78587ef3ce2d1a

Modified files:
        libpurple/protocols/msn/switchboard.c

ChangeLog: 

On MSN, when an error occurs when opening a switchboard and calling the 
user, don't unref the unsent messages, because msg_error_helper does it 
for us. Masca says this stopped the CAL 3 error crash.

Fixes #5377.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/switchboard.c	86dcb083a0e201348a7c56aa245ca3b937575747
+++ libpurple/protocols/msn/switchboard.c	64e8c8bc764df6a6691002ff72c722e9ba02db2d
@@ -1144,7 +1144,6 @@ cal_error(MsnCmdProc *cmdproc, MsnTransa
 		swboard->error = MSN_SB_ERROR_USER_OFFLINE;
 		msg_error_helper(swboard->cmdproc, msg,
 							 MSN_MSG_ERROR_SB);
-		msn_message_unref(msg);
 	}
 	cal_error_helper(trans, reason);
 }


More information about the Commits mailing list