pidgin: 889c6eed: Avoid a crash in OIM processing if the r...

qulogic at pidgin.im qulogic at pidgin.im
Thu Jul 17 01:31:01 EDT 2008


-----------------------------------------------------------------
Revision: 889c6eeda92624e506b1e771e8c58be72298b456
Ancestor: 5c5ae1b7efa28d9a5b76a5be3b0888149b8b0ab2
Author: qulogic at pidgin.im
Date: 2008-07-17T04:52:32
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/889c6eeda92624e506b1e771e8c58be72298b456

Modified files:
        libpurple/protocols/msn/oim.c

ChangeLog: 

Avoid a crash in OIM processing if the request was cancelled outside of 
the MSN code. Can be triggered by an invalid certificate, for example.

Fixes #6345.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/oim.c	688ad890e68527251a420db943761d798d879c24
+++ libpurple/protocols/msn/oim.c	38d53630521900b98b8f360259ead14377992b49
@@ -138,6 +138,9 @@ msn_oim_request_cb(MsnSoapMessage *reque
 	xmlnode *fault = NULL;
 	xmlnode *faultcode = NULL;
 
+	if (response == NULL)
+		return;
+
 	fault = xmlnode_get_child(response->xml, "Body/Fault");
 	if (fault)
 		faultcode = xmlnode_get_child(fault, "faultcode");


More information about the Commits mailing list