pidgin: 3f16d341: Daniel Atallah pointed out that this was...

markdoliner at markdoliner at
Thu Jul 17 12:11:10 EDT 2008

Revision: 3f16d341cc2215ed4d10d1f54ce9145961edf05f
Ancestor: 69fe72292fbbcc2a86b3bcc305e11608002ec176
Author: markdoliner at
Date: 2008-07-17T16:08:09
Branch: im.pidgin.pidgin

Modified files:


Daniel Atallah pointed out that this was obviously wrong.  So we would
have leaked a struct containing info about a chat if the connection
to the chatroom failed for any reason, or if you signed offline while
the connection was pending.  All better!

-------------- next part --------------
--- libpurple/protocols/oscar/flap_connection.c	c8ed02f63dc847bd5f6aead10f5b34d51ace6d49
+++ libpurple/protocols/oscar/flap_connection.c	d458e8c2acc90d87d95bca89a823fafac961ccfe
@@ -299,7 +299,7 @@ flap_connection_close(OscarData *od, Fla
 		conn->connect_data = NULL;
-	if (conn->connect_data != NULL)
+	if (conn->new_conn_data != NULL)
 		if (conn->type == SNAC_FAMILY_CHAT)

More information about the Commits mailing list