pidgin: 56b45029: Correct some IRC comments for /ctcp

elb at pidgin.im elb at pidgin.im
Mon Jul 21 16:40:48 EDT 2008


-----------------------------------------------------------------
Revision: 56b4502936b6bb088591317960079d1102554ec3
Ancestor: 8a1c165f0ab459826e0911c2dbdc1f20f47c7815
Author: elb at pidgin.im
Date: 2008-07-21T20:36:07
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/56b4502936b6bb088591317960079d1102554ec3

Modified files:
        libpurple/protocols/irc/cmds.c

ChangeLog: 

Correct some IRC comments for /ctcp

-------------- next part --------------
============================================================
--- libpurple/protocols/irc/cmds.c	ef5eea3673719c8516c5c98bba301240c48f9023
+++ libpurple/protocols/irc/cmds.c	e715ca17ce412ff4c254ebaaf5320980897d6590
@@ -79,8 +79,7 @@ int irc_cmd_ctcp(struct irc_conn *irc, c
 		return 0;
 
 	/* TODO:strip newlines or send each line as separate ctcp or something
-	 * actually, this shouldn't be done here but somewhere else since irc should support escaping newlines
-	 * utf8 could pose additional problems here since it allows some of weird chars (NULL) to be part of bigger chars */ 
+	 * actually, this shouldn't be done here but somewhere else since irc should support escaping newlines */
 
 	string = g_string_new(args[1]);
 	g_string_prepend_c (string,'\001');
@@ -88,17 +87,10 @@ int irc_cmd_ctcp(struct irc_conn *irc, c
 	buf = irc_format(irc, "vn:", "PRIVMSG", args[0], string->str);
 	g_string_free(string,TRUE);
 
-	/* check if line is small enough to send
-	 * XXX: strlen will prolly not work for UTF-8 */
-	if (strlen(buf) >= 512)
-		return 0;
-
 	irc_send(irc, buf);
 	g_free(buf);
 	
-
 	return 1;
-	
 }
 
 int irc_cmd_ctcp_action(struct irc_conn *irc, const char *cmd, const char *target, const char **args)


More information about the Commits mailing list