pidgin: d1162a26: Evan pointed out that this is purple_tim...

markdoliner at pidgin.im markdoliner at pidgin.im
Tue Jul 22 02:25:47 EDT 2008


-----------------------------------------------------------------
Revision: d1162a26436b062541b1171cadc8522d455069bb
Ancestor: 56b4502936b6bb088591317960079d1102554ec3
Author: markdoliner at pidgin.im
Date: 2008-07-22T06:23:54
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/d1162a26436b062541b1171cadc8522d455069bb

Modified files:
        libpurple/protocols/oscar/oscar.c

ChangeLog: 

Evan pointed out that this is purple_timeout_add_SECONDS, and so that "2"
is actually significant, and we could receive more oncoming SNACs
before the callback is triggered, and so it makes sense to wait a little
longer to increase the amount of coalescing.

-------------- next part --------------
============================================================
--- libpurple/protocols/oscar/oscar.c	999a7e16eccbe7b4fc95d4697d8771cc165b8a6a
+++ libpurple/protocols/oscar/oscar.c	ebfeebf3a0b4cfb446865c414ed92910a05e6d8e
@@ -2124,9 +2124,10 @@ static int purple_parse_oncoming(OscarDa
 					od->statusnotes_queue = g_slist_prepend(od->statusnotes_queue,
 							g_strdup(info->sn));
 
-					if (od->statusnotes_queue_timer == 0)
-						od->statusnotes_queue_timer = purple_timeout_add_seconds(2,
-								purple_requesticqstatusnote, gc);
+					if (od->statusnotes_queue_timer > 0)
+						purple_timeout_remove(od->statusnotes_queue_timer);
+					od->statusnotes_queue_timer = purple_timeout_add_seconds(2,
+							purple_requesticqstatusnote, gc);
 				}
 			}
 		}


More information about the Commits mailing list