pidgin: 26095209: Minor cleanup that's been sitting on my ...

datallah at pidgin.im datallah at pidgin.im
Tue Jul 29 15:01:13 EDT 2008


-----------------------------------------------------------------
Revision: 26095209492eae7f4532cb9b0cb4fdc9dfaac9e8
Ancestor: 8b1c0ea0c8e51378ba48d90d3f06867ea01c0fba
Author: datallah at pidgin.im
Date: 2008-07-29T18:53:00
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/26095209492eae7f4532cb9b0cb4fdc9dfaac9e8

Modified files:
        libpurple/protocols/msn/user.c

ChangeLog: 

Minor cleanup that's been sitting on my machine for a while.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/user.c	28cbd14450d2d51336f4da345504d59511d73c09
+++ libpurple/protocols/msn/user.c	81de621eb57b5b26774d00ffbf460c47e9a3f463
@@ -235,21 +235,19 @@ void
 
 /*add group id to User object*/
 void
-msn_user_add_group_id(MsnUser *user, const char* id)
+msn_user_add_group_id(MsnUser *user, const char* group_id)
 {
 	MsnUserList *userlist;
 	PurpleAccount *account;
 	PurpleBuddy *b;
 	PurpleGroup *g;
 	const char *passport;
-	char *group_id;
 	const char *group_name;
 
 	g_return_if_fail(user != NULL);
-	g_return_if_fail(id != NULL);
+	g_return_if_fail(group_id != NULL);
 
-	group_id = g_strdup(id);
-	user->group_ids = g_list_append(user->group_ids, group_id);
+	user->group_ids = g_list_append(user->group_ids, g_strdup(group_id));
 
 	userlist = user->userlist;
 	account = userlist->session->account;
@@ -261,7 +259,7 @@ msn_user_add_group_id(MsnUser *user, con
 
 	g = purple_find_group(group_name);
 
-	if ((id == NULL) && (g == NULL))
+	if ((group_id == NULL) && (g == NULL))
 	{
 		g = purple_group_new(group_name);
 		purple_blist_add_group(g, NULL);


More information about the Commits mailing list