pidgin: a93bdafd: Patch from Andrew Gaul that fixes a leak...

khc at pidgin.im khc at pidgin.im
Sun Jun 8 18:21:03 EDT 2008


-----------------------------------------------------------------
Revision: a93bdafd934907a3dd4a80a4b12d4c0e1101fec6
Ancestor: 7a36a9ecbcc902ee89656d5267e613aa1dc0b889
Author: khc at pidgin.im
Date: 2008-06-08T21:59:54
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/a93bdafd934907a3dd4a80a4b12d4c0e1101fec6

Modified files:
        pidgin/gtkimhtml.c

ChangeLog: 

Patch from Andrew Gaul that fixes a leak:

==13094== 190 (112 direct, 78 indirect) bytes in 6 blocks are definitely lost in loss record 111 of 290
==13094==    at 0x4A05854: calloc (vg_replace_malloc.c:397)
==13094==    by 0x331303F849: g_malloc0 (in /lib64/libglib-2.0.so.0.1600.3)
==13094==    by 0x47C5BE: text_tag_data_new (gtkimhtml.c:5121)
==13094==    by 0x47C9CC: gtk_imhtml_get_markup_range (gtkimhtml.c:5198)
==13094==    by 0x46EAEF: gtk_imhtml_clipboard_get (gtkimhtml.c:1007)


-------------- next part --------------
============================================================
--- pidgin/gtkimhtml.c	e6ae0026feb971ac37aa58db52e57945453e052c
+++ pidgin/gtkimhtml.c	229b1520bcd54efd4a256fc03b22a09150e04c41
@@ -5245,8 +5245,10 @@ char *gtk_imhtml_get_markup_range(GtkIMH
 
 				if (tmp == NULL)
 					purple_debug_warning("gtkimhtml", "empty queue, more closing tags than open tags!\n");
-				else
+				else {
 					g_string_append(str, tmp->end);
+					text_tag_data_destroy(tmp);
+				}
 
 				while ((tmp = g_queue_pop_head(r))) {
 					g_string_append(str, tmp->start);


More information about the Commits mailing list