pidgin: 78904b4a: Don't impose a restriction on who you ca...

datallah at pidgin.im datallah at pidgin.im
Fri Jun 13 21:15:39 EDT 2008


-----------------------------------------------------------------
Revision: 78904b4aec8280b63f8a2cae39f10b8edf53ae8d
Ancestor: e77dc2d1f8199cca004d39b2e703583fa1667bcd
Author: datallah at pidgin.im
Date: 2008-06-14T01:09:29
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/78904b4aec8280b63f8a2cae39f10b8edf53ae8d

Modified files:
        libpurple/protocols/jabber/si.c

ChangeLog: 

Don't impose a restriction on who you can send files to for XMPP.
This allows file transfers to arbitrary chat users (if you know their JID and
they know yours).
File transfers in chats where you don't know the real JID will fail because the
SOCKS5 DST.ADDR hash will not match on both clients (I can't see a way around
this issue right now).

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/si.c	f839bd5f0e4e8b0d5a11bce7a92f357ec1fc37fd
+++ libpurple/protocols/jabber/si.c	b22d4c91a87feb627c5acb261f349cf2bb77f9d4
@@ -806,7 +806,7 @@ jabber_si_xfer_bytestreams_listen_cb(int
 
 			g_snprintf(port, sizeof(port), "%hu", portnum);
 
-			purple_debug_info("jabber", "jabber_si_xfer_bytestreams_listen_cb() will be looking at jsx %p: jsx->streamhosts %p and ft_proxy_list[%i] %p",
+			purple_debug_info("jabber", "jabber_si_xfer_bytestreams_listen_cb() will be looking at jsx %p: jsx->streamhosts %p and ft_proxy_list[%i] %p\n",
 							  jsx, jsx->streamhosts, i, ft_proxy_list[i]);
 			if(g_list_find_custom(jsx->streamhosts, ft_proxy_list[i], jabber_si_compare_jid) != NULL)
 				continue;
@@ -1213,9 +1213,6 @@ void jabber_si_xfer_send(PurpleConnectio
 
 	js = gc->proto_data;
 
-	if(!purple_find_buddy(gc->account, who) || !jabber_buddy_find(js, who, FALSE))
-		return;
-
 	xfer = jabber_si_new_xfer(gc, who);
 
 	if (file)


More information about the Commits mailing list