pidgin: 541f6529: When purple_buddy_icons_set_account_icon...

evands at evands at
Mon Mar 3 19:50:41 EST 2008

Revision: 541f6529c3dbec16782707ce37eb8206f95fc92e
Ancestor: 312f2411c5843110ef07d5317c949b28eb9e5413
Author: evands at
Date: 2008-03-04T00:11:22
Branch: im.pidgin.pidgin

Modified files:


When purple_buddy_icons_set_account_icon() is called, it unrefs the old PurpleStoredImage and refs the new one.  Previously, it notified the prpl of the change in the buddy icon before updating pointer_icon_cache, which meant that if the prpl then called purple_buddy_icons_find_account_icon() it would get the old PurpleStoredImage (which is at this point not only old but also a pointer to invalid memory if unref'ing it caused it to be destroyed).  This happens in jabber_set_info() as of 2.4.0, causing a crash when setting no-buddy-icon for an account after it has previously had an icon. I think this also means that XMPP accounts in 2.4.0 will also always set serverside the *last* icon set, not the current one, when changing icons, but I didn't test that.
The solution is simple: Update pointer_icon_cache earlier, setting the new img if there is one or removing the account entirely from the hash table if there isn't one now.  This fixes both problems described above, making purple_buddy_icons_find_account_icon() return the new, current icon (or NULL) at all times.

-------------- next part --------------
--- libpurple/buddyicon.c	e7e68daa3510b42b31f8c472aa70d692a50180f7
+++ libpurple/buddyicon.c	d6392cd4c58357e01bfded407e7aa8f7ef101de6
@@ -701,6 +701,11 @@ purple_buddy_icons_set_account_icon(Purp
+	if (img)
+		g_hash_table_insert(pointer_icon_cache, account, img);
+	else
+		g_hash_table_remove(pointer_icon_cache, account);
 	if (purple_account_is_connected(account))
 		PurpleConnection *gc;
@@ -724,11 +729,6 @@ purple_buddy_icons_set_account_icon(Purp
-	if (img)
-		g_hash_table_insert(pointer_icon_cache, account, img);
-	else
-		g_hash_table_remove(pointer_icon_cache, account);
 	return img;

More information about the Commits mailing list