pidgin: 6d2081db: When Andrew was working on the memleak f...

khc at khc at
Sun Mar 9 17:45:49 EDT 2008

Revision: 6d2081db8269e8c34ebaa6579eba4dff4e3c8eac
Ancestor: 710538e38a278bc2f3c23d469ada0ab005d34c17
Author: khc at
Date: 2008-03-09T21:42:27
Branch: im.pidgin.pidgin

Modified files:


When Andrew was working on the memleak fixes, he pondered why buffer was
declared as:

char *buffer[16];

I changed it to char buffer[64] because 64 is 4 * 16 (I think? Someone
should double check since I got 256 the first try). I don't know if 16
is a more proper buffer size, but changing it to 64 should make it behave
more or less the same.

-------------- next part --------------
--- libpurple/protocols/irc/dcc_send.c	703f20f036d69388d9a1edf91f2acbeeb1bf9242
+++ libpurple/protocols/irc/dcc_send.c	1a4fa8f4acbf9eba0975da0c127750e6c9021c38
@@ -179,7 +179,7 @@ static void irc_dccsend_send_read(gpoint
 	PurpleXfer *xfer = data;
 	struct irc_xfer_send_data *xd = xfer->data;
-	char *buffer[16];
+	char buffer[64];
 	int len;
 	len = read(source, buffer, sizeof(buffer));

More information about the Commits mailing list