pidgin: 5c34be2e: Fix a memory leak

nosnilmot at pidgin.im nosnilmot at pidgin.im
Tue Mar 11 21:50:50 EDT 2008


-----------------------------------------------------------------
Revision: 5c34be2e2afa892d272763a3b1404664cc513e2d
Ancestor: 36c2bf4a9a6fedddf5d46c0c0cd993773eafb577
Author: nosnilmot at pidgin.im
Date: 2008-03-12T01:34:40
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/5c34be2e2afa892d272763a3b1404664cc513e2d

Modified files:
        pidgin/gtkblist.c

ChangeLog: 

Fix a memory leak

-------------- next part --------------
============================================================
--- pidgin/gtkblist.c	95ec8600374e086dbd2ff5eb1ca732f98af01ad2
+++ pidgin/gtkblist.c	51d4ecd45a0eb750ef09161369199396b2b1edde
@@ -3132,7 +3132,6 @@ static char *pidgin_get_tooltip_text(Pur
 		GList *cur;
 		struct proto_chat_entry *pce;
 		char *name, *value;
-		const char *chat_name;
 		PurpleConversation *conv;
 		PidginBlistNode *bnode = node->ui_data;
 
@@ -3150,13 +3149,15 @@ static char *pidgin_get_tooltip_text(Pur
 		if (bnode && bnode->conv.conv) {
 			conv = bnode->conv.conv;
 		} else {
+			char *chat_name;
 			if (prpl_info && prpl_info->get_chat_name)
 				chat_name = prpl_info->get_chat_name(chat->components);
 			else
-				chat_name = purple_chat_get_name(chat);
+				chat_name = g_strdup(purple_chat_get_name(chat));
 
 			conv = purple_find_conversation_with_account(PURPLE_CONV_TYPE_CHAT, chat_name,
 					chat->account);
+			g_free(chat_name);
 		}
 		if (conv && prpl_info && (prpl_info->options & OPT_PROTO_CHAT_TOPIC) &&
 				!purple_conv_chat_has_left(PURPLE_CONV_CHAT(conv))) {


More information about the Commits mailing list