pidgin: c27bb03d: Leak fix from SF bug #1407047 which actu...

[nosnilmot at pidgin.im]

-----------------------------------------------------------------
Revision: c27bb03d64e205ff26669ccc173b7429cad093eb
Ancestor: c8b2d8fd76b54ee11c854f9db5f8817247d748e8
Author: nosnilmot at pidgin.im
Date: 2008-03-13T01:34:09
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/c27bb03d64e205ff26669ccc173b7429cad093eb

Modified files:
        pidgin/gtkplugin.c

ChangeLog: 

Leak fix from SF bug #1407047 which actually had a patch attached (on 2006-01-17 !)

-------------- next part --------------
============================================================
--- pidgin/gtkplugin.c	b476115ba863dd5e50da53d6905604633d4fec74
+++ pidgin/gtkplugin.c	64b9740b40287aa81c287b58142e300b090b3c65
@@ -81,9 +81,7 @@ pidgin_plugin_get_config_frame(PurplePlu
 
 		config = pidgin_plugin_pref_create_frame(frame);
 
-		/* XXX According to bug #1407047 this broke saving pluging preferences, I'll look at fixing it correctly later.
-		purple_plugin_pref_frame_destroy(frame);
-		*/
+		plugin->info->prefs_info->frame = frame;
 	}
 
 	return config;
@@ -212,6 +210,12 @@ static void pref_dialog_response_cb(GtkW
 			plugin_pref_dialogs = NULL;
 		}
 		gtk_widget_destroy(d);
+
+		if (plug->info->prefs_info && plug->info->prefs_info->frame) {
+			purple_plugin_pref_frame_destroy(plug->info->prefs_info->frame);
+			plug->info->prefs_info->frame = NULL;
+		}
+
 		break;
 	}
 }