pidgin: 4afd9b8c: Add a comment. Could someone familiar w...

markdoliner at markdoliner at
Sun May 4 16:45:48 EDT 2008

Revision: 4afd9b8ce2a9c91ba21b92d2b86284bfee1a38e6
Ancestor: bc02373b5cfe8a046df6344d7b6833cab1003448
Author: markdoliner at
Date: 2008-05-04T20:44:08
Branch: im.pidgin.pidgin

Modified files:


Add a comment.  Could someone familiar with the Jabber protocol or our
Jabber PRPL comment on this (or change my comment to an explanatory one?)
Etan?  Nathan?  Thanks!

-------------- next part --------------
--- libpurple/protocols/jabber/roster.c	f9eb1e8c18fbec6fbbae94a91fb88d6b7f647216
+++ libpurple/protocols/jabber/roster.c	193709e4db9351f19545578b1f06c9e4cafb71f6
@@ -329,6 +329,14 @@ void jabber_roster_add_buddy(PurpleConne
 	jb = jabber_buddy_find(js, buddy->name, FALSE);
+	/*
+	 * For some reason if we're waiting for our subscription request
+	 * to be approved and we try to add the buddy to another group
+	 * then we remove the buddy from the old group.  I don't understand
+	 * the rationale for this, can someone please explain it?  It seems
+	 * like we should pass NULL as the groups parameter to
+	 * jabber_roster_update().
+	 */
 	if(!jb || !(jb->subscription & JABBER_SUB_TO)) {
 		groups = g_slist_append(groups, group->name);

More information about the Commits mailing list