pidgin: 68e91ac2: Patch from QuLogic to fix tab-navigation...

sadrul at pidgin.im sadrul at pidgin.im
Wed May 7 23:21:45 EDT 2008


-----------------------------------------------------------------
Revision: 68e91ac241a8cba7102b6f868b76189a265c6d5b
Ancestor: 4955af47f51251e1bc160a9fbbd177cca708d81c
Author: sadrul at pidgin.im
Date: 2008-05-08T03:20:28
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/68e91ac241a8cba7102b6f868b76189a265c6d5b

Modified files:
        pidgin/gtkconv.c pidgin/gtkstatusbox.c

ChangeLog: 

Patch from QuLogic to fix tab-navigation in the statusbox. And a few
missing GDK_ISO_Left_Tab. Closes #3843, #4386.

-------------- next part --------------
============================================================
--- pidgin/gtkconv.c	8ca7a4c2bc3215d8ad67faf22d70046de4eb78b8
+++ pidgin/gtkconv.c	ed64fb67b2f5b1084f848a0fc6b3fa8920d16aaa
@@ -1901,6 +1901,7 @@ conv_keypress_common(PidginConversation 
 				break;
 
 			case GDK_Tab:
+			case GDK_KP_Tab:
 			case GDK_ISO_Left_Tab:
 				if (event->state & GDK_SHIFT_MASK) {
 					move_to_next_unread_tab(gtkconv, FALSE);
@@ -2082,6 +2083,8 @@ entry_key_press_cb(GtkWidget *entry, Gdk
 	else {
 		switch (event->keyval) {
 		case GDK_Tab:
+		case GDK_KP_Tab:
+		case GDK_ISO_Left_Tab:
 			if (gtkconv->entry != entry)
 				break;
 			return tab_complete(conv);
@@ -2152,6 +2155,7 @@ refocus_entry_cb(GtkWidget *widget, GdkE
 		(event->keyval == GDK_Home) ||
 		(event->keyval == GDK_End) ||
 		(event->keyval == GDK_Tab) ||
+		(event->keyval == GDK_KP_Tab) ||
 		(event->keyval == GDK_ISO_Left_Tab))
 	{
 		if (event->type == GDK_KEY_PRESS)
============================================================
--- pidgin/gtkstatusbox.c	08182f8933b8864f84e299c4039da568111a8ef0
+++ pidgin/gtkstatusbox.c	6d0c6e3d15d5ecba8e8bd3068e69686594044050
@@ -1131,7 +1131,7 @@ static gboolean imhtml_remove_focus(GtkW
 
 static gboolean imhtml_remove_focus(GtkWidget *w, GdkEventKey *event, PidginStatusBox *status_box)
 {
-	if (event->keyval == GDK_Tab || event->keyval == GDK_KP_Tab)
+	if (event->keyval == GDK_Tab || event->keyval == GDK_KP_Tab || event->keyval == GDK_ISO_Left_Tab)
 	{
 		/* If last inserted character is a tab, then remove the focus from here */
 		GtkWidget *top = gtk_widget_get_toplevel(w);
@@ -1458,7 +1458,7 @@ toggle_key_press_cb(GtkWidget *widget, G
 			}
 			return TRUE;
 		default:
-			return TRUE;
+			return FALSE;
 	}
 }
 


More information about the Commits mailing list