pidgin: f824db1e: Reduce the enormous padding in the group...

sadrul at pidgin.im sadrul at pidgin.im
Sun May 18 16:40:53 EDT 2008


-----------------------------------------------------------------
Revision: f824db1e8c1daf31945411fb916a834506ef1d85
Ancestor: 22210e3f8a7bb24230b23ad7e83a49903bbe9d60
Author: sadrul at pidgin.im
Date: 2008-05-18T20:26:14
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/f824db1e8c1daf31945411fb916a834506ef1d85

Modified files:
        pidgin/gtkblist.c

ChangeLog: 

Reduce the enormous padding in the group tooltip. People will hopefully dislike it less now.

-------------- next part --------------
============================================================
--- pidgin/gtkblist.c	6c6c215b535ff617df4d7b0dd67be0f0a68d0c6e
+++ pidgin/gtkblist.c	1b0f68789cab5507069210a2e8363fe0e3019996
@@ -2653,6 +2653,7 @@ struct tooltip_data {
 	int name_width;
 	int width;
 	int height;
+	int padding;
 };
 
 static PangoLayout * create_pango_layout(const char *markup, int *width, int *height)
@@ -2681,6 +2682,7 @@ static struct tooltip_data * create_tip_
 	if (purple_account_is_disconnected(account))
 		gdk_pixbuf_saturate_and_pixelate(td->status_icon, td->status_icon, 0.0, FALSE);
 	td->layout = create_pango_layout(purple_account_get_username(account), &td->width, &td->height);
+	td->padding = SMALL_SPACE;
 	return td;
 }
 
@@ -2696,6 +2698,7 @@ static struct tooltip_data * create_tip_
 		account = ((PurpleChat*)(node))->account;
 	}
 
+	td->padding = TOOLTIP_BORDER;
 	td->status_icon = pidgin_blist_get_status_icon(node, PIDGIN_STATUS_ICON_LARGE);
 	td->avatar = pidgin_blist_get_buddy_icon(node, !full, FALSE);
 	if (account != NULL) {
@@ -2861,7 +2864,7 @@ pidgin_blist_paint_tip(GtkWidget *widget
 			}
 		}
 
-		current_height += MAX(td->name_height + td->height, td->avatar_height) + TOOLTIP_BORDER;
+		current_height += MAX(td->name_height + td->height, td->avatar_height) + td->padding;
 	}
 	return FALSE;
 }
@@ -2952,8 +2955,7 @@ pidgin_blist_create_tooltip_for_node(Gtk
 		struct tooltip_data *td = list->data;
 		max_text_width = MAX(max_text_width, MAX(td->width, td->name_width));
 		max_avatar_width = MAX(max_avatar_width, td->avatar_width);
-		height += MAX(TOOLTIP_BORDER + MAX(STATUS_SIZE, td->avatar_height),
-				TOOLTIP_BORDER + td->height + td->name_height);
+		height += MAX(MAX(STATUS_SIZE, td->avatar_height), td->height + td->name_height) + td->padding;
 		if (td->status_icon)
 			status_size = MAX(status_size, STATUS_SIZE);
 	}


More information about the Commits mailing list