pidgin: 0d6ca2d4: Fix a potential leak, thanks to "KuSh". ...

[datallah at pidgin.im]

-----------------------------------------------------------------
Revision: 0d6ca2d4cfeb63a55ed7b9507d318afbfbc9ada8
Ancestor: eb27c61e427e040d34c8af1ff2ab1e5b85c91807
Author: datallah at pidgin.im
Date: 2008-11-07T02:52:31
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/0d6ca2d4cfeb63a55ed7b9507d318afbfbc9ada8

Modified files:
        libpurple/protocols/sametime/sametime.c

ChangeLog: 

Fix a potential leak, thanks to "KuSh".  Fixes #7464.

-------------- next part --------------
============================================================
--- libpurple/protocols/sametime/sametime.c	f57a2836e3579dc767727265d04760f695730200
+++ libpurple/protocols/sametime/sametime.c	dab0b7d6c3a41bd313462023f934be90569e512a
@@ -4490,27 +4490,25 @@ static void mw_prpl_add_buddy(PurpleConn
 			      PurpleBuddy *buddy,
 			      PurpleGroup *group) {
 
-  struct mwPurplePluginData *pd;
+  struct mwPurplePluginData *pd = gc->proto_data;
   struct mwServiceResolve *srvc;
   GList *query;
   enum mwResolveFlag flags;
   guint32 req;
-
   BuddyAddData *data;
 
+  /* catch external buddies. They won't be in the resolve service */
+  if(buddy_is_external(buddy)) {
+    buddy_add(pd, buddy);
+    return;
+  }
+
   data = g_new0(BuddyAddData, 1);
   data->buddy = buddy;
   data->group = group;
 
-  pd = gc->proto_data;
   srvc = pd->srvc_resolve;
 
-  /* catch external buddies. They won't be in the resolve service */
-  if(buddy_is_external(buddy)) {
-    buddy_add(pd, buddy);
-    return;
-  }
-
   query = g_list_prepend(NULL, buddy->name);
   flags = mwResolveFlag_FIRST | mwResolveFlag_USERS;