pidgin: eac2c72e: Move a few lines to eliminate the need f...

markdoliner at pidgin.im markdoliner at pidgin.im
Wed Nov 12 04:35:29 EST 2008


-----------------------------------------------------------------
Revision: eac2c72efc00cb5ed00e29d52bb7be6fcdc5b3c0
Ancestor: 66352dab5a562440ff0b5c5486abcaef3ae65ced
Author: markdoliner at pidgin.im
Date: 2008-11-12T09:32:10
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/eac2c72efc00cb5ed00e29d52bb7be6fcdc5b3c0

Modified files:
        libpurple/protocols/msn/httpconn.c

ChangeLog: 

Move a few lines to eliminate the need for the "wasted" variable here.
I think this is simpler.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/httpconn.c	fe14d76e6323ddd6232dbcf8e3e755ea33d82012
+++ libpurple/protocols/msn/httpconn.c	0adb9eb20f8345babc8beb67dfaf1561d9ce37fa
@@ -64,7 +64,6 @@ msn_httpconn_parse_data(MsnHttpConn *htt
 	const char *body_start;
 	char *tmp;
 	size_t body_len = 0;
-	gboolean wasted = FALSE;
 
 	g_return_val_if_fail(httpconn != NULL, FALSE);
 	g_return_val_if_fail(buf      != NULL, FALSE);
@@ -217,15 +216,10 @@ msn_httpconn_parse_data(MsnHttpConn *htt
 
 		g_free(tmp);
 
-		if ((session_action != NULL) && (strcmp(session_action, "close") == 0))
-			wasted = TRUE;
-
-		g_free(session_action);
-
 		t = strchr(full_session_id, '.');
 		session_id = g_strndup(full_session_id, t - full_session_id);
 
-		if (!wasted)
+		if (session_action == NULL || strcmp(session_action, "close") != 0)
 		{
 			g_free(httpconn->full_session_id);
 			httpconn->full_session_id = full_session_id;
@@ -254,6 +248,8 @@ msn_httpconn_parse_data(MsnHttpConn *htt
 			g_free(session_id);
 			g_free(gw_ip);
 		}
+
+		g_free(session_action);
 	}
 
 	g_free(header);


More information about the Commits mailing list